xuzifu666 commented on code in PR #5342:
URL: https://github.com/apache/calcite/pull/5342#discussion_r4307540620
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -3920,6 +3920,42 @@ public void checkOrderBy(final boolean desc,
+ "empid=200; deptno=20; name=Eric; salary=8000.0;
commission=500\n");
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-4531";>[CALCITE-4531]
+ * Deprecate RexLiteral#intValue since it performs silent truncation</a>.
+ *
+ * <p>LIMIT greater than the maximum int value used to be silently
+ * truncated, so "limit 2^40" became "limit 0" and the query silently
+ * returned no rows. */
+ @Test void testLimitExceedsMaxInt() {
Review Comment:
The two tests mentioned in the Jira discussion are also included here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
