xiedeyantu commented on code in PR #5347:
URL: https://github.com/apache/calcite/pull/5347#discussion_r4324181855
##########
.github/pull_request_template.md:
##########
@@ -7,19 +7,35 @@ Thanks for sending a pull request! Here are some critical
tips for you:
2. JIRA IS USUALLY MANDATORY: Ensure you have created an issue on the Calcite
Jira:
https://issues.apache.org/jira/projects/CALCITE/issues
*Check existing issues first to avoid duplicates.*
- *Note: A Jira is NOT required for typos and cosmetic changes (i.e., changes
that are neither bugs nor features).*
+ *Exceptions: Use `[TEST]` for test additions or `[MINOR]` for other minor
changes, such as typos and cosmetic changes. These prefixes do not require a
Jira issue.*
Review Comment:
You’re right—the current "allowlist" is too restrictive. Looking at the
local commit history, I see that it includes not only updates from `Site:` and
`Dependabot`, but also reverts and descriptive titles used for tests or minor
changes.
Furthermore, the existing `LintTest` rejects prefixes that don’t follow the
Jira format (such as `[MINOR]`), which means the `[TEST]` / `[MINOR]`
convention I introduced conflicts with the current validation rules.
I suggest the following: if a title contains a Jira prefix, we validate the
corresponding Jira reference; otherwise, we allow descriptive titles without a
Jira prefix—bypassing validation for these cases to provide more flexibility.
This would eliminate the need to maintain an ever-growing list of "special
prefixes." What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
