zzwqqq commented on code in PR #5350:
URL: https://github.com/apache/calcite/pull/5350#discussion_r4345678785


##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -301,6 +301,12 @@ public class SqlToRelConverter {
   private final Map<CorrelationId, DeferredLookup> mapCorrelToDeferred =
       new HashMap<>();
 
+  /**
+   * Maps an inner join whose ON condition has expanded sub-queries to the
+   * cross join of its inputs.
+   */
+  private final Map<RelNode, RelNode> mapJoinToCrossJoin = new HashMap<>();

Review Comment:
   Could we derive the field offsets from the scope's namespaces, as 
getCorrelationUse does, instead of adding mapJoinToCrossJoin?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to