vlsi commented on PR #2571: URL: https://github.com/apache/calcite/pull/2571#issuecomment-6341114805
Thanks for the PR, and sorry it sat for so long. The failure from CALCITE-4833 is gone on `main`: [CALCITE-5638](https://issues.apache.org/jira/browse/CALCITE-5638) (commit 00e09ac15e, released in 1.40.0) fixed the field trimmer and `SubQueryRemoveRule`, and `SELECT t1.empid FROM emps t1 LEFT JOIN emps t2 ON (SELECT t2.empid)<=100` now returns all four employees. Every query from this PR's test returns the expected rows on `main` as well, and so does a correlated sub-query with a `FROM` in `ON`, such as `(SELECT count(*) FROM depts d WHERE d.deptno = t2.deptno) > 0`, which the rewrite here would not cover. I'm closing this PR. If you have a query that still fails on `main`, please file a new JIRA issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
