xuzifu666 commented on PR #5354: URL: https://github.com/apache/calcite/pull/5354#issuecomment-6382844392
> You can check whether it's solved now. I have performed the relevant verification, They address different problems: 1. Different code paths. https://github.com/apache/calcite/commit/73b05e37c75bc38e663be7dcd87315324b44a9e5 convertInnerJoinWithSubQueries intercepts INNER JOIN + expand=true before convertOnCondition is entered, so this pr convertCorrelatedScalarSubqueryInOn never runs in that scenario. 2. Different plans: For the INNER JOIN test case, https://github.com/apache/calcite/commit/73b05e37c75bc38e663be7dcd87315324b44a9e5 produces a cross-join-then-filter structure, while this pr embeds the sub-query into the right input — structurally distinct plans confirming different logic. 3. Non-overlapping coverage. https://github.com/apache/calcite/commit/73b05e37c75bc38e663be7dcd87315324b44a9e5 independently handles LEFT JOIN and expand=false cases, which this pr does not touch. The LEFT JOIN test (testOnClauseCorrelatedScalarSubquery) passes with CALCITE-4340 logic alone after rebase. At the same time, without code changes the related test case would fail. @mihaibudiu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
