dajiaohuang opened a new pull request, #5358: URL: https://github.com/apache/calcite/pull/5358
## Jira Link [CALCITE-7820](https://issues.apache.org/jira/browse/CALCITE-7820) ## Changes Proposed Setting `nonReservedKeywordsToRemove: ["ADD"]` currently leaves `ADD` usable as an unquoted identifier, contrary to the documented parser configuration contract. Filter the combined base and added non-reserved keyword list before splitting it into the three grammar productions. This makes removal take effect while preserving the existing configuration fallbacks and partitioning. The generated extension-parser regression checks reserved-word metadata, rejection of unquoted `ADD`, `AFTER`, and `BEFORE`, acceptance of their quoted forms, and continued acceptance of the unaffected `KEY` identifier. Validation: - The new regression fails on the original template (`ADD` is not reserved). - `:core:test --tests '*ExtensionSqlParserTest'`: successful, 520 tests, 0 failures, 3 skipped. - `./gradlew build`: successful, 413 tasks, with no test exclusions added. Local fixture tests used the default configuration; optional external integrations were not enabled. AI assistance: OpenAI Codex helped implement and validate this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
