rubenada commented on code in PR #5334: URL: https://github.com/apache/calcite/pull/5334#discussion_r4400509127
########## site/_docs/history.md: ########## @@ -114,6 +114,19 @@ check the width of each group, and turned `1-2-3-4-5` into requires exactly 16 bytes; a longer value used to be truncated. Blanks are not trimmed. +* [<a href="https://issues.apache.org/jira/browse/CALCITE-7860";>CALCITE-7860</a>] +The file adapter now dereferences only local `file:` sources by default. Table +`url` operands naming remote protocols (`http`, `https`, `ftp`, ...; including +`jar:`, even when it wraps a local file) are rejected with +`IllegalArgumentException` unless they match the new +`calcite.file.urls.allowed` system property, a regular expression that must +match the whole URL, for example +`-Dcalcite.file.urls.allowed=https://data\.example\.com/.*`. A +`file:` URL that names a host (`file://host/...`, or a Windows UNC path) is +remote too, and also requires a match; this includes +`file://localhost/...`. See +[Enabling remote fetches]({{ site.baseurl }}/docs/file_adapter.html#enabling-remote-fetches). Review Comment: release note simplified ########## site/_docs/file_adapter.md: ########## @@ -344,6 +353,55 @@ sqlline> select distinct deptno from depts; 3 rows selected (0.985 seconds) {% endhighlight %} +## Enabling remote fetches Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
