rubenada commented on code in PR #5373:
URL: https://github.com/apache/calcite/pull/5373#discussion_r4416269889
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##########
@@ -1086,15 +1086,15 @@ public Result visit(TableScan e) {
}
private static SqlHint toSqlHint(RelHint hint, SqlParserPos pos) {
- if (hint.kvOptions != null) {
+ if (!hint.kvOptions.isEmpty()) {
Review Comment:
unrelated minor issue unveiled by this patch: `hint.kvOptions` and
`hint.listOptions` are never null (they are empty map / list if not present,
see RelHint constructor)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
