Mrhs121 commented on code in PR #5396: URL: https://github.com/apache/calcite/pull/5396#discussion_r4500908973
########## core/src/test/java/org/apache/calcite/rel/metadata/RelMdExpressionLineageTest.java: ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.metadata; + +import org.apache.calcite.jdbc.JavaTypeFactoryImpl; +import org.apache.calcite.plan.RelOptPredicateList; +import org.apache.calcite.plan.hep.HepPlanner; +import org.apache.calcite.plan.hep.HepProgramBuilder; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Calc; +import org.apache.calcite.rel.logical.LogicalFilter; +import org.apache.calcite.rel.rules.CoreRules; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql.type.SqlTypeName; + +import com.google.common.collect.ImmutableSet; + +import org.checkerframework.checker.nullness.qual.Nullable; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; + +import java.math.BigDecimal; +import java.util.AbstractSet; +import java.util.Iterator; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.Random; +import java.util.Set; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** Tests for bounded expression-lineage expansion. */ +class RelMdExpressionLineageTest { + private final RexBuilder rexBuilder = new RexBuilder(new JavaTypeFactoryImpl()); + + @ParameterizedTest + @CsvSource({"1, 1", "2, 2", "2, 4", "4, 4", "8, 4", "16, 4", "90, 4", "2, 16"}) + void testGeneratedPrograms(int branches, int columns) throws Exception { + for (boolean window : new boolean[] {false, true}) { + for (boolean calc : new boolean[] {false, true}) { + RelNode rel = ExpressionLineageProgram.rel(branches, columns, window); + if (calc) { + HepPlanner planner = new HepPlanner(new HepProgramBuilder() + .addRuleInstance(CoreRules.PROJECT_TO_CALC).build()); + planner.setRoot(rel); + rel = planner.findBestExp(); + assertTrue(rel instanceof Calc, "Expected the Calc metadata path"); + } + RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RexNode result = RexInputRef.of(columns, rel.getRowType().getFieldList()); + Set<RexNode> lineage = mq.getExpressionLineage(rel, result); + if (Math.pow(branches, columns) > 10_000) { + // No truncated subset may escape as complete metadata. Review Comment: Done. ########## core/src/test/java/org/apache/calcite/rel/metadata/RelMdExpressionLineageTest.java: ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.metadata; + +import org.apache.calcite.jdbc.JavaTypeFactoryImpl; +import org.apache.calcite.plan.RelOptPredicateList; +import org.apache.calcite.plan.hep.HepPlanner; +import org.apache.calcite.plan.hep.HepProgramBuilder; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Calc; +import org.apache.calcite.rel.logical.LogicalFilter; +import org.apache.calcite.rel.rules.CoreRules; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql.type.SqlTypeName; + +import com.google.common.collect.ImmutableSet; + +import org.checkerframework.checker.nullness.qual.Nullable; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; + +import java.math.BigDecimal; +import java.util.AbstractSet; +import java.util.Iterator; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.Random; +import java.util.Set; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** Tests for bounded expression-lineage expansion. */ +class RelMdExpressionLineageTest { + private final RexBuilder rexBuilder = new RexBuilder(new JavaTypeFactoryImpl()); + + @ParameterizedTest + @CsvSource({"1, 1", "2, 2", "2, 4", "4, 4", "8, 4", "16, 4", "90, 4", "2, 16"}) + void testGeneratedPrograms(int branches, int columns) throws Exception { + for (boolean window : new boolean[] {false, true}) { + for (boolean calc : new boolean[] {false, true}) { + RelNode rel = ExpressionLineageProgram.rel(branches, columns, window); + if (calc) { + HepPlanner planner = new HepPlanner(new HepProgramBuilder() + .addRuleInstance(CoreRules.PROJECT_TO_CALC).build()); + planner.setRoot(rel); + rel = planner.findBestExp(); + assertTrue(rel instanceof Calc, "Expected the Calc metadata path"); + } + RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RexNode result = RexInputRef.of(columns, rel.getRowType().getFieldList()); + Set<RexNode> lineage = mq.getExpressionLineage(rel, result); + if (Math.pow(branches, columns) > 10_000) { + // No truncated subset may escape as complete metadata. + assertNull(lineage); + } else { + assertNotNull(lineage); + assertEquals((int) Math.pow(branches, columns), lineage.size()); + } + // An expensive result must not poison other columns or later queries. Review Comment: Done. ########## core/src/test/java/org/apache/calcite/rel/metadata/RelMdExpressionLineageTest.java: ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.metadata; + +import org.apache.calcite.jdbc.JavaTypeFactoryImpl; +import org.apache.calcite.plan.RelOptPredicateList; +import org.apache.calcite.plan.hep.HepPlanner; +import org.apache.calcite.plan.hep.HepProgramBuilder; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Calc; +import org.apache.calcite.rel.logical.LogicalFilter; +import org.apache.calcite.rel.rules.CoreRules; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql.type.SqlTypeName; + +import com.google.common.collect.ImmutableSet; + +import org.checkerframework.checker.nullness.qual.Nullable; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; + +import java.math.BigDecimal; +import java.util.AbstractSet; +import java.util.Iterator; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.Random; +import java.util.Set; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** Tests for bounded expression-lineage expansion. */ +class RelMdExpressionLineageTest { + private final RexBuilder rexBuilder = new RexBuilder(new JavaTypeFactoryImpl()); + + @ParameterizedTest + @CsvSource({"1, 1", "2, 2", "2, 4", "4, 4", "8, 4", "16, 4", "90, 4", "2, 16"}) + void testGeneratedPrograms(int branches, int columns) throws Exception { + for (boolean window : new boolean[] {false, true}) { + for (boolean calc : new boolean[] {false, true}) { + RelNode rel = ExpressionLineageProgram.rel(branches, columns, window); + if (calc) { + HepPlanner planner = new HepPlanner(new HepProgramBuilder() + .addRuleInstance(CoreRules.PROJECT_TO_CALC).build()); + planner.setRoot(rel); + rel = planner.findBestExp(); + assertTrue(rel instanceof Calc, "Expected the Calc metadata path"); + } + RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RexNode result = RexInputRef.of(columns, rel.getRowType().getFieldList()); + Set<RexNode> lineage = mq.getExpressionLineage(rel, result); + if (Math.pow(branches, columns) > 10_000) { + // No truncated subset may escape as complete metadata. + assertNull(lineage); + } else { + assertNotNull(lineage); + assertEquals((int) Math.pow(branches, columns), lineage.size()); + } + // An expensive result must not poison other columns or later queries. + Set<RexNode> passthrough = mq.getExpressionLineage(rel, + RexInputRef.of(0, rel.getRowType().getFieldList())); + assertNotNull(passthrough); + assertEquals(branches, passthrough.size()); + assertEquals(lineage, mq.getExpressionLineage(rel, result)); + rel.getCluster().invalidateMetadataQuery(); + assertEquals(lineage, rel.getCluster().getMetadataQuery() + .getExpressionLineage(rel, result)); + } + } + } + + @Test void testBudgetBoundaryAndMappingUnchanged() { Review Comment: Done. ########## core/src/test/java/org/apache/calcite/rel/metadata/RelMdExpressionLineageTest.java: ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.metadata; + +import org.apache.calcite.jdbc.JavaTypeFactoryImpl; +import org.apache.calcite.plan.RelOptPredicateList; +import org.apache.calcite.plan.hep.HepPlanner; +import org.apache.calcite.plan.hep.HepProgramBuilder; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Calc; +import org.apache.calcite.rel.logical.LogicalFilter; +import org.apache.calcite.rel.rules.CoreRules; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql.type.SqlTypeName; + +import com.google.common.collect.ImmutableSet; + +import org.checkerframework.checker.nullness.qual.Nullable; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; + +import java.math.BigDecimal; +import java.util.AbstractSet; +import java.util.Iterator; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.Random; +import java.util.Set; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** Tests for bounded expression-lineage expansion. */ +class RelMdExpressionLineageTest { + private final RexBuilder rexBuilder = new RexBuilder(new JavaTypeFactoryImpl()); + + @ParameterizedTest + @CsvSource({"1, 1", "2, 2", "2, 4", "4, 4", "8, 4", "16, 4", "90, 4", "2, 16"}) + void testGeneratedPrograms(int branches, int columns) throws Exception { + for (boolean window : new boolean[] {false, true}) { + for (boolean calc : new boolean[] {false, true}) { + RelNode rel = ExpressionLineageProgram.rel(branches, columns, window); + if (calc) { + HepPlanner planner = new HepPlanner(new HepProgramBuilder() + .addRuleInstance(CoreRules.PROJECT_TO_CALC).build()); + planner.setRoot(rel); + rel = planner.findBestExp(); + assertTrue(rel instanceof Calc, "Expected the Calc metadata path"); + } + RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RexNode result = RexInputRef.of(columns, rel.getRowType().getFieldList()); + Set<RexNode> lineage = mq.getExpressionLineage(rel, result); + if (Math.pow(branches, columns) > 10_000) { + // No truncated subset may escape as complete metadata. + assertNull(lineage); + } else { + assertNotNull(lineage); + assertEquals((int) Math.pow(branches, columns), lineage.size()); + } + // An expensive result must not poison other columns or later queries. + Set<RexNode> passthrough = mq.getExpressionLineage(rel, + RexInputRef.of(0, rel.getRowType().getFieldList())); + assertNotNull(passthrough); + assertEquals(branches, passthrough.size()); + assertEquals(lineage, mq.getExpressionLineage(rel, result)); + rel.getCluster().invalidateMetadataQuery(); + assertEquals(lineage, rel.getCluster().getMetadataQuery() + .getExpressionLineage(rel, result)); + } + } + } + + @Test void testBudgetBoundaryAndMappingUnchanged() { + RexInputRef a = ref(0); + RexInputRef b = ref(1); + RexNode expression = rexBuilder.makeCall(SqlStdOperatorTable.MINUS, a, b); + Map<RexInputRef, Set<RexNode>> mapping = mapping(a, b); + Map<RexInputRef, Set<RexNode>> original = new LinkedHashMap<>(mapping); + Set<RexNode> unlimited = expand(expression, mapping, -1); + assertNotNull(unlimited); + assertEquals(4, unlimited.size()); + assertEquals(unlimited, expand(expression, mapping, 4)); + assertNull(expand(expression, mapping, 3)); + assertEquals(original, mapping); + assertEquals(unlimited, expand(expression, mapping, 5)); + } + + @Test void testGeneratedProgramExceedsBudget() throws Exception { + RelNode rel = ExpressionLineageProgram.rel(16, 4, true); + Set<RexNode> lineage = rel.getCluster().getMetadataQuery().getExpressionLineage(rel, + RexInputRef.of(4, rel.getRowType().getFieldList())); + assertTrue(lineage == null, () -> "Expected unknown lineage, not " + + (lineage == null ? "null" : lineage.size()) + " candidates"); + } + + @Test void testBudgetCountsAttemptsBeforeDeduplication() { + RexInputRef a = ref(0); + RexInputRef b = ref(1); + RexNode expression = rexBuilder.makeCall(SqlStdOperatorTable.PLUS, a, b); + Map<RexInputRef, Set<RexNode>> mapping = mapping(a, b); + // Commutative normalization merges 1 + 10 and 10 + 1, but constructing + // both still takes work. Budgeting the result Set size would miss this. + Set<RexNode> unlimited = expand(expression, mapping, -1); + assertNotNull(unlimited); + assertEquals(3, unlimited.size()); + assertEquals(unlimited, expand(expression, mapping, 4)); + assertNull(expand(expression, mapping, 3)); + } + + @Test void testRepeatedAndUnusedReferences() { Review Comment: Only distinct, referenced columns contribute to the estimate. That was the reason for the test, but it doesn't need a separate case here. Removed. ########## core/src/test/java/org/apache/calcite/rel/metadata/RelMdExpressionLineageTest.java: ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.metadata; + +import org.apache.calcite.jdbc.JavaTypeFactoryImpl; +import org.apache.calcite.plan.RelOptPredicateList; +import org.apache.calcite.plan.hep.HepPlanner; +import org.apache.calcite.plan.hep.HepProgramBuilder; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Calc; +import org.apache.calcite.rel.logical.LogicalFilter; +import org.apache.calcite.rel.rules.CoreRules; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql.type.SqlTypeName; + +import com.google.common.collect.ImmutableSet; + +import org.checkerframework.checker.nullness.qual.Nullable; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; + +import java.math.BigDecimal; +import java.util.AbstractSet; +import java.util.Iterator; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.Random; +import java.util.Set; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** Tests for bounded expression-lineage expansion. */ +class RelMdExpressionLineageTest { + private final RexBuilder rexBuilder = new RexBuilder(new JavaTypeFactoryImpl()); + + @ParameterizedTest + @CsvSource({"1, 1", "2, 2", "2, 4", "4, 4", "8, 4", "16, 4", "90, 4", "2, 16"}) + void testGeneratedPrograms(int branches, int columns) throws Exception { + for (boolean window : new boolean[] {false, true}) { + for (boolean calc : new boolean[] {false, true}) { + RelNode rel = ExpressionLineageProgram.rel(branches, columns, window); + if (calc) { + HepPlanner planner = new HepPlanner(new HepProgramBuilder() + .addRuleInstance(CoreRules.PROJECT_TO_CALC).build()); + planner.setRoot(rel); + rel = planner.findBestExp(); + assertTrue(rel instanceof Calc, "Expected the Calc metadata path"); + } + RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RexNode result = RexInputRef.of(columns, rel.getRowType().getFieldList()); + Set<RexNode> lineage = mq.getExpressionLineage(rel, result); + if (Math.pow(branches, columns) > 10_000) { + // No truncated subset may escape as complete metadata. + assertNull(lineage); + } else { + assertNotNull(lineage); + assertEquals((int) Math.pow(branches, columns), lineage.size()); + } + // An expensive result must not poison other columns or later queries. + Set<RexNode> passthrough = mq.getExpressionLineage(rel, + RexInputRef.of(0, rel.getRowType().getFieldList())); + assertNotNull(passthrough); + assertEquals(branches, passthrough.size()); + assertEquals(lineage, mq.getExpressionLineage(rel, result)); + rel.getCluster().invalidateMetadataQuery(); + assertEquals(lineage, rel.getCluster().getMetadataQuery() + .getExpressionLineage(rel, result)); + } + } + } + + @Test void testBudgetBoundaryAndMappingUnchanged() { + RexInputRef a = ref(0); + RexInputRef b = ref(1); + RexNode expression = rexBuilder.makeCall(SqlStdOperatorTable.MINUS, a, b); + Map<RexInputRef, Set<RexNode>> mapping = mapping(a, b); + Map<RexInputRef, Set<RexNode>> original = new LinkedHashMap<>(mapping); + Set<RexNode> unlimited = expand(expression, mapping, -1); + assertNotNull(unlimited); + assertEquals(4, unlimited.size()); + assertEquals(unlimited, expand(expression, mapping, 4)); + assertNull(expand(expression, mapping, 3)); + assertEquals(original, mapping); + assertEquals(unlimited, expand(expression, mapping, 5)); + } + + @Test void testGeneratedProgramExceedsBudget() throws Exception { + RelNode rel = ExpressionLineageProgram.rel(16, 4, true); + Set<RexNode> lineage = rel.getCluster().getMetadataQuery().getExpressionLineage(rel, + RexInputRef.of(4, rel.getRowType().getFieldList())); + assertTrue(lineage == null, () -> "Expected unknown lineage, not " + + (lineage == null ? "null" : lineage.size()) + " candidates"); + } + + @Test void testBudgetCountsAttemptsBeforeDeduplication() { + RexInputRef a = ref(0); + RexInputRef b = ref(1); + RexNode expression = rexBuilder.makeCall(SqlStdOperatorTable.PLUS, a, b); + Map<RexInputRef, Set<RexNode>> mapping = mapping(a, b); + // Commutative normalization merges 1 + 10 and 10 + 1, but constructing + // both still takes work. Budgeting the result Set size would miss this. + Set<RexNode> unlimited = expand(expression, mapping, -1); + assertNotNull(unlimited); + assertEquals(3, unlimited.size()); + assertEquals(unlimited, expand(expression, mapping, 4)); + assertNull(expand(expression, mapping, 3)); + } + + @Test void testRepeatedAndUnusedReferences() { + RexInputRef a = ref(0); + RexInputRef b = ref(1); + RexNode expression = rexBuilder.makeCall(SqlStdOperatorTable.MINUS, a, a); + Map<RexInputRef, Set<RexNode>> mapping = mapping(a, b); + // Only a is referenced: repeated occurrences share a substitution, and + // unused b must not contribute a dimension to the product. + assertEquals(expand(expression, mapping, -1), expand(expression, mapping, 2)); + assertNull(expand(expression, mapping, 1)); + } + + @Test void testZeroBudgetAndConstants() { Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
