rubenada commented on code in PR #5393: URL: https://github.com/apache/calcite/pull/5393#discussion_r4510800208
########## core/src/test/java/org/apache/calcite/test/CollectionTypeTest.java: ########## @@ -54,9 +62,8 @@ import static org.junit.jupiter.api.Assertions.fail; /** - * Tests for collection types, including - * <a href="https://issues.apache.org/jira/browse/CALCITE-1386";>[CALCITE-1386] - * ITEM operator seems to ignore the value type of collection and assign the value to Object</a>. + * Tests for collection and structured types, including nested values, Review Comment: I think it is better to not alter this javadoc and keep the original comment; it says "Tests for collection types, **including** ...", which means these are not exclusive for CALCITE-1386, so I think it's better to keep this referece ########## core/src/test/java/org/apache/calcite/test/CollectionTypeTest.java: ########## @@ -54,9 +62,8 @@ import static org.junit.jupiter.api.Assertions.fail; /** - * Tests for collection types, including - * <a href="https://issues.apache.org/jira/browse/CALCITE-1386";>[CALCITE-1386] - * ITEM operator seems to ignore the value type of collection and assign the value to Object</a>. + * Tests for collection and structured types, including nested values, Review Comment: I think it is better to not alter this javadoc and keep the original comment; it says "Tests for collection types, **including** ...", which means these are not exclusive for CALCITE-1386, so I think it's better to keep this reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
