sbroeder commented on code in PR #5399:
URL: https://github.com/apache/calcite/pull/5399#discussion_r4517677121
##########
core/src/main/java/org/apache/calcite/sql/advise/SqlAdvisorValidator.java:
##########
@@ -184,17 +182,54 @@ private void registerId(SqlIdentifier id,
SqlValidatorScope scope) {
}
}
+ /**
+ * Masks type-inference {@link CalciteException} during validation of
+ * sub-expressions so that the advisor can continue providing hints even
+ * when a namespace fails to validate, for example an unknown column in
+ * an incomplete SQL fragment.
+ */
+ @Override protected void inferUnknownTypes(
Review Comment:
> Your issue title should probably make it clear that this is an advisor
problem.
I made an effort to revise the title. I'm worried it might be long. Happy
to alter if you have a preferred text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
