rubenada commented on code in PR #5370:
URL: https://github.com/apache/calcite/pull/5370#discussion_r4535255041
##########
core/src/main/java/org/apache/calcite/sql/SqlWithItem.java:
##########
@@ -50,11 +51,19 @@ public SqlWithItem(SqlParserPos pos, SqlIdentifier name,
public SqlWithItem(SqlParserPos pos, SqlIdentifier name,
@Nullable SqlNodeList columnList, SqlNode query,
SqlLiteral recursive, @Nullable SqlCycleClause cycleClause) {
+ this(pos, name, columnList, query, recursive, null, cycleClause);
Review Comment:
nit: for consistency, either we remove this constructor, or provide an
equivalent one with SqlSearchClause and without SqlCycleClause. Since this has
not been released yet, I think it is better to simply remove this one, and just
have the "old" constructors + a new one with both optional parameters
(SqlSearchClause and SqlCycleClause)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
