zzwqqq commented on PR #5385: URL: https://github.com/apache/calcite/pull/5385#issuecomment-6828118409
> I only left a few superficial comments. > > This is a very complicated change. It could benefit from a high-level description of the strategy employed. The way I imagine I may approach this is by rewriting queries to segregate non-deterministic computations only to appear in some specific query operators (e.g., project) to simplify the job of the decorrelator. Thanks for the review. I've added a strategy overview to the PR description. I tried a small prototype based on your suggestion, covering Filter and INNER JOIN conditions. It let the determinism scan skip those operators' conditions, but added a normalization pass and still needed the shared expression visitor for correlation analysis. I haven't found an overall simplification in this prototype, so I'd lean toward keeping the current approach for this PR. Curious what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
