aldettinger commented on a change in pull request #1619:
URL: https://github.com/apache/camel-quarkus/pull/1619#discussion_r477233308



##########
File path: 
extensions/flatpack/deployment/src/main/java/org/apache/camel/quarkus/component/flatpack/deployment/FlatpackProcessor.java
##########
@@ -36,8 +34,4 @@ NativeImageResourceBuildItem registerNativeImageResources() {
         return new 
NativeImageResourceBuildItem("net/sf/flatpack/xml/flatpack.dtd", 
"fpconvert.properties");
     }
 
-    @BuildStep
-    ReflectiveClassBuildItem registerReflectiveClasses() {
-        return new ReflectiveClassBuildItem(false, false, 
FlatpackException.class);

Review comment:
       There is just the cost of embedding this class while it may not be used. 
But, yeah there is not real harm and that could prevent camel-quarkus user to 
register this camel class. I'm gonna drop this commit and push locally.
   Many thanks all for review :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to