This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new 0a44f5c Polished
0a44f5c is described below
commit 0a44f5cc66c641434e0e0c301e377193dea86829
Author: Claus Ibsen <[email protected]>
AuthorDate: Sun Sep 20 11:22:47 2020 +0200
Polished
---
.../component/google/sheets/GoogleSheetsEndpoint.java | 1 -
.../sheets/stream/GoogleSheetsStreamConfiguration.java | 18 ------------------
.../camel/support/component/AbstractApiEndpoint.java | 4 ----
3 files changed, 23 deletions(-)
diff --git
a/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/GoogleSheetsEndpoint.java
b/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/GoogleSheetsEndpoint.java
index e8b4115..09f4359 100644
---
a/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/GoogleSheetsEndpoint.java
+++
b/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/GoogleSheetsEndpoint.java
@@ -66,7 +66,6 @@ public class GoogleSheetsEndpoint extends
AbstractApiEndpoint<GoogleSheetsApiNam
throw new IllegalArgumentException("Option inBody is not supported
for consumer endpoint");
}
final GoogleSheetsConsumer consumer = new GoogleSheetsConsumer(this,
processor);
- // also set consumer.* properties
configureConsumer(consumer);
return consumer;
}
diff --git
a/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/stream/GoogleSheetsStreamConfiguration.java
b/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/stream/GoogleSheetsStreamConfiguration.java
index 096dbe8..cb4fa4e 100644
---
a/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/stream/GoogleSheetsStreamConfiguration.java
+++
b/components/camel-google-sheets/src/main/java/org/apache/camel/component/google/sheets/stream/GoogleSheetsStreamConfiguration.java
@@ -145,8 +145,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* Gets the apiName.
- *
- * @return
*/
public String getApiName() {
return apiName;
@@ -154,8 +152,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* Sets the apiName.
- *
- * @param apiName
*/
public void setApiName(String apiName) {
this.apiName = apiName;
@@ -167,8 +163,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* Specifies the spreadsheet identifier that is used to identify the
target to obtain.
- *
- * @param spreadsheetId
*/
public void setSpreadsheetId(String spreadsheetId) {
this.spreadsheetId = spreadsheetId;
@@ -181,8 +175,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* Specify the maximum number of returned results. This will limit the
number of rows in a returned value range data
* set or the number of returned value ranges in a batch request.
- *
- * @param maxResults
*/
public void setMaxResults(int maxResults) {
this.maxResults = maxResults;
@@ -194,8 +186,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* Specifies the range of rows and columns in a sheet to get data from.
- *
- * @param range
*/
public void setRange(String range) {
this.range = range;
@@ -207,8 +197,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* Specifies the major dimension that results should use..
- *
- * @param majorDimension
*/
public void setMajorDimension(String majorDimension) {
this.majorDimension = majorDimension;
@@ -220,8 +208,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* Determines how values should be rendered in the output.
- *
- * @param valueRenderOption
*/
public void setValueRenderOption(String valueRenderOption) {
this.valueRenderOption = valueRenderOption;
@@ -233,8 +219,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
/**
* True if grid data should be returned.
- *
- * @param includeGridData
*/
public void setIncludeGridData(boolean includeGridData) {
this.includeGridData = includeGridData;
@@ -248,8 +232,6 @@ public class GoogleSheetsStreamConfiguration implements
Cloneable {
* True if value range result should be split into rows or columns to
process each of them individually. When true
* each row or column is represented with a separate exchange in batch
processing. Otherwise value range object is
* used as exchange junk size.
- *
- * @param splitResults
*/
public void setSplitResults(boolean splitResults) {
this.splitResults = splitResults;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java
b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java
index 363fd26..0a187b4 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java
@@ -97,10 +97,6 @@ public abstract class AbstractApiEndpoint<E extends ApiName,
T>
@Override
public void configureProperties(Map<String, Object> options) {
super.configureProperties(options);
- // TODO: this is not very clean as it does not leverage the endpoint
- // TODO: configurer, but the generated configurer currently does not
- // TODO: support configuration inheritance, so only basic options
- // TODO: are supported. This should be fixed.
setProperties(getConfiguration(), options);
// validate and initialize state
