[camel] branch master updated: CAMEL-15533: camel-slack - improve error if empty channel option. Also move init logic to doStart for the consumer

[davsclaus]

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new e0aa882  CAMEL-15533: camel-slack - improve error if empty channel 
option. Also move init logic to doStart for the consumer
e0aa882 is described below

commit e0aa882d0992da5daa028a8cb72748ea49dcc4d2
Author: Claus Ibsen <claus.ib...@gmail.com>
AuthorDate: Mon Dec 7 18:28:39 2020 +0100

    CAMEL-15533: camel-slack - improve error if empty channel option. Also move 
init logic to doStart for the consumer
---
 .../main/java/org/apache/camel/component/slack/SlackConsumer.java    | 5 +++++
 .../main/java/org/apache/camel/component/slack/SlackEndpoint.java    | 4 ++++
 2 files changed, 9 insertions(+)

diff --git 
a/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackConsumer.java
 
b/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackConsumer.java
index 5da148f..2550559 100644
--- 
a/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackConsumer.java
+++ 
b/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackConsumer.java
@@ -52,6 +52,11 @@ public class SlackConsumer extends 
ScheduledBatchPollingConsumer {
     public SlackConsumer(SlackEndpoint endpoint, Processor processor) throws 
IOException, DeserializationException {
         super(endpoint, processor);
         this.slackEndpoint = endpoint;
+    }
+
+    @Override
+    protected void doStart() throws Exception {
+        super.doStart();
         this.channelId = getChannelId(slackEndpoint.getChannel());
     }
 
diff --git 
a/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackEndpoint.java
 
b/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackEndpoint.java
index 325649c..c5bf928 100644
--- 
a/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackEndpoint.java
+++ 
b/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackEndpoint.java
@@ -86,6 +86,10 @@ public class SlackEndpoint extends ScheduledPollEndpoint {
             throw new RuntimeCamelException(
                     "Missing required endpoint configuration: token must be 
defined for Slack consumer");
         }
+        if (ObjectHelper.isEmpty(channel)) {
+            throw new RuntimeCamelException(
+                    "Missing required endpoint configuration: channel must be 
defined for Slack consumer");
+        }
         SlackConsumer consumer = new SlackConsumer(this, processor);
         configureConsumer(consumer);
         return consumer;