zregvart commented on a change in pull request #509:
URL: https://github.com/apache/camel-website/pull/509#discussion_r545903632
##########
File path: .gitignore
##########
@@ -20,3 +20,5 @@ resources
!**/.yarn/sdks
!**/.yarn/unplugged
!**/.yarn/versions
+
+.pnp
Review comment:
Yeah, I don't think it should be ignored, PNP stands for plug and play
which is a Yarn feature that replaces node_modules, we also use another Yarn
feature called zero install that vendors all the dependencies. The end result
is, if you checkout the repository you don't need to fetch anything to build.
For example, we don't need `yarn install` on the CI:
https://github.com/apache/camel-website/blob/33fedc838299b8b0b84aa24726ff813eb7ec5218/Jenkinsfile#L58
In that way it's odd that you get this file/directory created, as we also
have a GitHub action that checks that everything is present in `.yarn` and in
sync with `.pnp.js` and `yarn.lock`:
https://github.com/apache/camel-website/blob/33fedc838299b8b0b84aa24726ff813eb7ec5218/.github/workflows/pr.yaml#L28
Nevermind, I'll remove that from .gitignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
