oscerd commented on a change in pull request #4909:
URL: https://github.com/apache/camel/pull/4909#discussion_r562431745



##########
File path: 
components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MiloClientProducer.java
##########
@@ -53,7 +57,15 @@ public boolean process(Exchange exchange, AsyncCallback 
async) {
 
         final CompletableFuture<?> future;
 
-        if (this.methodId == null) {
+        if (msg.getHeaders().containsKey(HEADER_NODE_IDS)) {

Review comment:
       You're changing the default behavior here, so it would be better if you 
add more documentation under src/main/docs of the project

##########
File path: 
components/camel-milo/src/test/java/org/apache/camel/component/milo/ReadValuesClientTest.java
##########
@@ -0,0 +1,66 @@
+package org.apache.camel.component.milo;

Review comment:
       Please add the ASF license header




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to