This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new 02af1c0  Slack: Re-use http client and consume response (#4990)
02af1c0 is described below

commit 02af1c0349dfbe6f103e86128c90f04cdff96bb7
Author: Claus Ibsen <[email protected]>
AuthorDate: Tue Feb 2 18:07:06 2021 +0100

    Slack: Re-use http client and consume response (#4990)
---
 .../java/org/apache/camel/component/slack/SlackProducer.java   | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git 
a/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackProducer.java
 
b/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackProducer.java
index cac89c6..494379e 100644
--- 
a/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackProducer.java
+++ 
b/components/camel-slack/src/main/java/org/apache/camel/component/slack/SlackProducer.java
@@ -39,7 +39,6 @@ import org.apache.http.util.EntityUtils;
 public class SlackProducer extends DefaultAsyncProducer {
 
     private final SlackEndpoint slackEndpoint;
-
     private CloseableHttpAsyncClient client;
 
     public SlackProducer(SlackEndpoint endpoint) {
@@ -50,14 +49,18 @@ public class SlackProducer extends DefaultAsyncProducer {
     @Override
     protected void doStart() throws Exception {
         this.client = 
HttpAsyncClientBuilder.create().useSystemProperties().build();
+        this.client.start();
+
         super.doStart();
     }
 
     @Override
     protected void doStop() throws Exception {
         super.doStop();
+
         if (client != null) {
             client.close();
+            client = null;
         }
     }
 
@@ -96,16 +99,19 @@ public class SlackProducer extends DefaultAsyncProducer {
             public void completed(HttpResponse response) {
                 // 2xx is OK, anything else we regard as failure
                 if (response.getStatusLine().getStatusCode() < 200 || 
response.getStatusLine().getStatusCode() > 299) {
-                    exchange.setException(new CamelExchangeException("Error 
POSTing to Slack API: " + response.toString(), exchange));
+                    exchange.setException(
+                            new CamelExchangeException("Error POSTing to Slack 
API: " + response.toString(), exchange));
                 }
                 EntityUtils.consumeQuietly(response.getEntity());
                 callback.done(false);
             }
+
             @Override
             public void failed(Exception ex) {
                 exchange.setException(ex);
                 callback.done(false);
             }
+
             @Override
             public void cancelled() {
                 callback.done(false);

Reply via email to