astefanutti commented on a change in pull request #2040: URL: https://github.com/apache/camel-k/pull/2040#discussion_r578995319
########## File path: pkg/trait/toleration.go ########## @@ -0,0 +1,154 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package trait + +import ( + "fmt" + "regexp" + "strconv" + + appsv1 "k8s.io/api/apps/v1" + "k8s.io/api/batch/v1beta1" + corev1 "k8s.io/api/core/v1" + serving "knative.dev/serving/pkg/apis/serving/v1" + + v1 "github.com/apache/camel-k/pkg/apis/camel/v1" + "github.com/apache/camel-k/pkg/util" +) + +// This trait will set a Toleration over an integration pod. Tolerations allow (but do not require) the pods to schedule onto nodes with matching taints. +// See https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ for more details. +// +// The toleration should be expressed in a similar manner of taints *_Key[=Value]:Effect[:Seconds]_* where values in square brackets are optional. Examples: +// +// my-key:NoExecute +// com.example/my-key:NoExecute +// com.example/my-key=my-val:NoSchedule +// com.example/my-key=my-val:NoSchedule:120 +// +// It's disabled by default. +// +// +camel-k:trait=toleration +type tolerationTrait struct { + BaseTrait `property:",squash"` + // The taint to tolerate in the form Key[=Value]:Effect[:Seconds] Review comment: Nit: "taint" -> "taints" ########## File path: pkg/trait/toleration.go ########## @@ -0,0 +1,154 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package trait + +import ( + "fmt" + "regexp" + "strconv" + + appsv1 "k8s.io/api/apps/v1" + "k8s.io/api/batch/v1beta1" + corev1 "k8s.io/api/core/v1" + serving "knative.dev/serving/pkg/apis/serving/v1" + + v1 "github.com/apache/camel-k/pkg/apis/camel/v1" + "github.com/apache/camel-k/pkg/util" +) + +// This trait will set a Toleration over an integration pod. Tolerations allow (but do not require) the pods to schedule onto nodes with matching taints. Review comment: Nit: I'd suggest "This trait sets Tolerations over Integration pods". ########## File path: docs/modules/traits/pages/toleration.adoc ########## @@ -0,0 +1,44 @@ += Toleration Trait + +// Start of autogenerated code - DO NOT EDIT! (description) +This trait will set a Toleration over an integration pod. Tolerations allow (but do not require) the pods to schedule onto nodes with matching taints. +See https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ for more details. + +The toleration should be expressed in a similar manner of taints *_Key[=Value]:Effect[:Seconds]_* where values in square brackets are optional. Examples: + +my-key:NoExecute Review comment: I'd suggest to add actual examples, like adding toleration to schedule pods on master nodes, e.g. `node-role.kubernetes.io/master:NoSchedule`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
