orpiske commented on a change in pull request #2252:
URL: https://github.com/apache/camel-k/pull/2252#discussion_r623846874
##########
File path: pkg/trait/logging.go
##########
@@ -35,12 +38,18 @@ type loggingTrait struct {
BaseTrait `property:",squash"`
// Colorize the log output
Color *bool `property:"color" json:"color,omitempty"`
+ // Output the log in json format
+ Json *bool `property:"json" json:"json,omitempty"`
+ // Enable "pretty printing" of the json log
+ JsonPrettyPrint *bool `property:"json.pretty-print"
json:"json.pretty-print,omitempty"`
Review comment:
BTW, as for the name ... I am a bit concerned that it will eventually
become confusing for the user when/if we include additional traits. For
example, naming it as just "prettyPrint" looks a bit confusing when we also
have "color". Since Quarkus seems to have quite a [lot of
options](https://quarkus.io/guides/logging) we might choose to "expose", it can
become a bit confusing.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
