orpiske commented on a change in pull request #5588: URL: https://github.com/apache/camel/pull/5588#discussion_r635340190
########## File path: test-infra/camel-test-infra-openldap/src/test/java/org/apache/camel/test/infra/openldap/common/OpenldapProperties.java ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel.test.infra.openldap.common; + +public final class OpenldapProperties { + public static final String HOST = "openldap.host"; + public static final String PORT_389 = "openldap.port.389"; + public static final String PORT_636 = "openldap.port.636"; Review comment: For clarity, maybe use `PORT_LDAP` and `PORT_LDAP_OVER_SSL` along with `openldap.port.ldap` and `openldap.port.ldap.ssl` respectively? I had to google what these ports are ... so, it would make it easier to figure it out in the future. ########## File path: test-infra/camel-test-infra-openldap/src/test/java/org/apache/camel/test/infra/openldap/services/OpenldapLocalContainerService.java ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.test.infra.openldap.services; + +import org.apache.camel.test.infra.common.services.ContainerService; +import org.apache.camel.test.infra.openldap.common.OpenldapProperties; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.FixedHostPortGenericContainer; +import org.testcontainers.containers.GenericContainer; + +public class OpenldapLocalContainerService implements OpenldapService, ContainerService<GenericContainer> { + public static final String CONTAINER_IMAGE = "osixia/openldap:1.5.0"; + public static final String CONTAINER_NAME = "openldap"; + public static final int CONTAINER_PORT_389 = 389; + public static final int CONTAINER_PORT_636 = 636; Review comment: Maybe use `CONTAINER_PORT_LDAP` and `CONTAINER_PORT_LDAP_OVER_SSL` for clarity? Not necessarily these, but a descriptive name would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
