ppalaga commented on a change in pull request #2661:
URL: https://github.com/apache/camel-quarkus/pull/2661#discussion_r638609985



##########
File path: catalog/pom.xml
##########
@@ -2979,7 +2979,7 @@
         </dependency>
         <dependency>
             <groupId>org.apache.camel.quarkus</groupId>
-            <artifactId>camel-quarkus-qute</artifactId>
+            <artifactId>camel-quarkus-qute-component</artifactId>

Review comment:
       These virtual deps only serve as module ordering hints for mvnd or mvn 
-T. Moreover they are 100% generated. If you run `mvn process-resources 
-Pformat -N` from the repo root (which recommended after changing 
dependencies), the change will get reverted. Could you please explain your 
motivation for the change?

##########
File path: catalog/pom.xml
##########
@@ -4416,6 +4416,7 @@
                             </extensionDirectories>
                             <skipArtifactIdBases>
                                 
<skipArtifactIdBase>http-common</skipArtifactIdBase>
+                                <skipArtifactIdBase>qute</skipArtifactIdBase>

Review comment:
       Wouldn't this actually exclude the Qute component from the Camel Quarkus 
Catalog? - Is that what you want?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to