lburgazzoli opened a new issue #2335:
URL: https://github.com/apache/camel-k/issues/2335


   If `controller-gen` or `kustomize` are not found, my understanding is that 
those binaries are downloaded and installed in $(GOBIN) which may lead to 
issues as it may override the version one has already downloaded:
   
   ```
   # find or download controller-gen if necessary
   controller-gen:
   ifeq (, $(shell which controller-gen))
        @{ \
        set -e ;\
        CONTROLLER_GEN_TMP_DIR=$$(mktemp -d) ;\
        cd $$CONTROLLER_GEN_TMP_DIR ;\
        go mod init tmp ;\
        go get sigs.k8s.io/controller-tools/cmd/[email protected] ;\
        rm -rf $$CONTROLLER_GEN_TMP_DIR ;\
        }
   CONTROLLER_GEN=$(GOBIN)/controller-gen
   else
   CONTROLLER_GEN=$(shell which controller-gen)
   endif
   
   kustomize:
   ifeq (, $(shell which kustomize))
        @{ \
        set -e ;\
        KUSTOMIZE_GEN_TMP_DIR=$$(mktemp -d) ;\
        cd $$KUSTOMIZE_GEN_TMP_DIR ;\
        go mod init tmp ;\
        go get sigs.k8s.io/kustomize/kustomize/[email protected] ;\
        rm -rf $$KUSTOMIZE_GEN_TMP_DIR ;\
        }
   KUSTOMIZE=$(GOBIN)/kustomize
   else
   KUSTOMIZE=$(shell which kustomize)
   endif
   ```
   
   I think any project specific binary should be downloaded and installed on a 
temporary location relative to the project root
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to