astefanutti commented on pull request #2292:
URL: https://github.com/apache/camel-k/pull/2292#issuecomment-854659480


   > @astefanutti I had to put this work on hold, but came back today. The 
deployment status doesn't show the pod status, that's why the monitor_pod.go 
inspects the pod status.
   
   What about the current ReplicaSet? Also Conditions may provide some useful 
info.
   
   > I added monitor_pod.go specific action because the CanHandle function 
accepts to run when integration phase is in running or error.
   
   There are already the `monitor` and `error` action. I understand it may be 
simpler from this specific issue point of view to create a new action, but it 
seems a bit an anti-pattern to have multiple actions bound to the same phases. 
The general approach is to have a single action for a given resource phase.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to