johnpoth commented on a change in pull request #2383:
URL: https://github.com/apache/camel-k/pull/2383#discussion_r648974683
##########
File path: pkg/cmd/install.go
##########
@@ -321,6 +323,26 @@ func (o *installCmdOptions) install(cobraCmd
*cobra.Command, _ []string) error {
}
}
}
+
+ if size := len(o.MavenBuildExtension); size > 0 {
+ platform.Spec.Build.Maven.Extension =
make([]v1.Extension, 0, size)
+ for _, extension := range o.MavenBuildExtension {
+ gav := strings.Split(extension, ":")
Review comment:
There is a
[ParseGav](https://github.com/apache/camel-k/blob/main/pkg/util/maven/maven_command.go#L242)
method (if that's what you had in mind ?). I thought about using it but I see
two problems :
1. It allows classifiers and packaging types which isn't allowed for
extensions
2. The error message isn't quite adapted (due to 1.)
Let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
