squakez commented on a change in pull request #2427:
URL: https://github.com/apache/camel-k/pull/2427#discussion_r656024728
##########
File path: pkg/trait/jvm.go
##########
@@ -54,6 +54,8 @@ type jvmTrait struct {
DebugAddress string `property:"debug-address"
json:"debugAddress,omitempty"`
// A list of JVM options
Options []string `property:"options" json:"options,omitempty"`
+ // A list of additional JVM classpaths
+ Classpaths []string `property:"classpaths" json:"classpaths,omitempty"`
Review comment:
Yeah, the only concern that I have there is that `cp` syntax is
different for each operating system. A `Windows` user may be using a `;`
resulting in a runtime error because not recognized by `Linux`. Maybe we can
just document it and leave it as a single property (I didn't like the plural
`classpaths` either...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
