claudio4j commented on a change in pull request #2467:
URL: https://github.com/apache/camel-k/pull/2467#discussion_r661585113
##########
File path: pkg/cmd/run.go
##########
@@ -801,6 +800,8 @@ func resolvePodTemplate(ctx context.Context, templateSrc
string, spec *v1.Integr
func configureTraits(options []string, catalog *trait.Catalog)
(map[string]v1.TraitSpec, error) {
traits := make(map[string]map[string]interface{})
+ // remove any duplicate trait parameters in case it is set as modeline
or command line parameters
+ util.StringsSliceRemoveDuplicates(&options)
Review comment:
At this point there is no difference about the trait values, so the
duplicate routine checks the trait name and value. I think it would be
appropriate to check only the names, similar to the property key names, wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
