pgalbraith edited a comment on pull request #5824: URL: https://github.com/apache/camel/pull/5824#issuecomment-882214403
@oscerd what do you think of this alternative? It's clearly less code so cleaner from that perspective. I prefer the original commit, though, because: 1. This introduces a new protected API method that needs to be supported going forwards 2. If you extend the WebsocketEndpoint and change parameters in your endpoint constructor, they will be (possibly) overridden by init code in the component createEndpoint method. This is not intuitive behaviour to me ... endpoint is a natural Camel extension point so I would expect that parameters I set in my endpoint constructor will 'stick'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
