astefanutti commented on a change in pull request #2535:
URL: https://github.com/apache/camel-k/pull/2535#discussion_r678971625
##########
File path: pkg/trait/pull_secret.go
##########
@@ -122,6 +122,10 @@ func (t *pullSecretTrait) newImagePullerRoleBinding(e
*Environment) *rbacv1.Role
serviceAccount = "default"
}
return &rbacv1.RoleBinding{
Review comment:
Ah looking at the offending commit, I wonder whether it might been
better to revert back to having the trait managing the resource directly
instead of adding it the environment resources. It's not a typical resource,
and it seems safer to manage it directly to avoid any new side effect in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
