orpiske commented on pull request #2540: URL: https://github.com/apache/camel-k/pull/2540#issuecomment-890956477
> > > > > @orpiske would this env var lead to a warning if the json loggign extension is not on the classpath ? > > > > > > > > > > > > I believe the warning should go away in this case. I was looking in the code and we are already including the [quarkus-logging-json in the classpath](https://github.com/apache/camel-k/blob/main/pkg/trait/logging.go?rgh-link-date=2021-08-02T11%3A29%3A32Z#L32) when the json logging is true. > > > > Now that we changed the default behavior if unset, I don't think we should get into a situation where it tries to log via json and it is not on the classpath. What do you think? > > > > > > > > > Looks good to me, wonder if we can add `io.quarkus:quarkus-logging-json` as transitive dependency o camel-k so this trait would not need to change the dependencies. This would also ensure the dependency to be present inc case you provide your own container image > > > > > > The only likely downside is that we would need release both the runtime and camel K if we decide to backport this fix ... but, frankly, I am fine with both approaches. > > Maybe we could add it [here in the Runtime](https://github.com/apache/camel-k-runtime/blob/main/camel-k-runtime/runtime/pom.xml?rgh-link-date=2021-08-02T11%3A29%3A32Z#L30)? > > I think we can defer this additional dependency to camel-k 1.6 & camel-k-runtime 1.9 Deal. Let me merge this as a work-around for now, then I'll backport it to 1.5. I'll add a task to myself to do this cleanup in the 1.6 time frame and will take care of it when I come back from PTO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
