aldettinger commented on a change in pull request #3059: URL: https://github.com/apache/camel-quarkus/pull/3059#discussion_r699520012
########## File path: docs/modules/ROOT/pages/contributor-guide/release-guide.adoc ########## @@ -233,13 +233,61 @@ Check the full [release announcement](https://camel.apache.org/blog/2021/06/came + * Click the green "Publish release" button at the bottom +== Upgrade and tag Examples + +* Make sure all https://github.com/apache/camel-quarkus-examples/pulls[PRs] against `camel-quarkus-main` branch are merged. +* Upgrade to the Camel Quarkus version you just released ++ +[source,shell] +---- +$ NEW_CQ_VERSION=... # E.g. 2.2.0 +$ git fetch upstream +$ git checkout camel-quarkus-main +$ git reset --hard upstream/camel-quarkus-main +$ find . -type f -name pom.xml -exec sed -i "s|<camel-quarkus.version>[^<]*</camel-quarkus.version>|<camel-quarkus.version>$NEW_CQ_VERSION</camel-quarkus.version>|g" {} \; Review comment: Can't we do it with `./mvnw-for-each.sh versions:set` ? ########## File path: docs/modules/ROOT/pages/contributor-guide/release-guide.adoc ########## @@ -233,13 +233,61 @@ Check the full [release announcement](https://camel.apache.org/blog/2021/06/came + * Click the green "Publish release" button at the bottom +== Upgrade and tag Examples + +* Make sure all https://github.com/apache/camel-quarkus-examples/pulls[PRs] against `camel-quarkus-main` branch are merged. +* Upgrade to the Camel Quarkus version you just released ++ +[source,shell] +---- +$ NEW_CQ_VERSION=... # E.g. 2.2.0 +$ git fetch upstream +$ git checkout camel-quarkus-main +$ git reset --hard upstream/camel-quarkus-main +$ find . -type f -name pom.xml -exec sed -i "s|<camel-quarkus.version>[^<]*</camel-quarkus.version>|<camel-quarkus.version>$NEW_CQ_VERSION</camel-quarkus.version>|g" {} \; +$ ./mvnw-for-each.sh org.l2x6.cq:cq-maven-plugin:0.25.0:sync-example-properties +$ git commit -m "Upgrade to Camel Quarkus $NEW_CQ_VERSION" +---- ++ +* Make sure that the tests are still passing: ++ +[source,shell] +---- +$ ./mvnw-for-each.sh clean verify -Pnative +---- ++ +* If everything works for you locally, open a PR to merge `camel-quarkus-main` to `main` +* Once the PR is merged, tag the `main` branch with the `$NEW_CQ_VERSION`: ++ +[source,shell] +---- +$ git checkout main +$ git fetch upstream +$ git reset --hard upstream/main +$ ./mvnw-for-each.sh versions:set -DnewVersion=$NEW_CQ_VERSION Review comment: I don't catch something. Are we setting the versions a second time ? Feel like it was already done on camel-quarkus-main and then merged ? ########## File path: docs/modules/ROOT/pages/contributor-guide/release-guide.adoc ########## @@ -233,13 +233,61 @@ Check the full [release announcement](https://camel.apache.org/blog/2021/06/came + * Click the green "Publish release" button at the bottom +== Upgrade and tag Examples + +* Make sure all https://github.com/apache/camel-quarkus-examples/pulls[PRs] against `camel-quarkus-main` branch are merged. +* Upgrade to the Camel Quarkus version you just released ++ +[source,shell] +---- +$ NEW_CQ_VERSION=... # E.g. 2.2.0 +$ git fetch upstream +$ git checkout camel-quarkus-main +$ git reset --hard upstream/camel-quarkus-main +$ find . -type f -name pom.xml -exec sed -i "s|<camel-quarkus.version>[^<]*</camel-quarkus.version>|<camel-quarkus.version>$NEW_CQ_VERSION</camel-quarkus.version>|g" {} \; Review comment: ok, this was part of the misunderstanding. so, that's fine. ########## File path: docs/modules/ROOT/pages/contributor-guide/release-guide.adoc ########## @@ -233,13 +233,61 @@ Check the full [release announcement](https://camel.apache.org/blog/2021/06/came + * Click the green "Publish release" button at the bottom +== Upgrade and tag Examples + +* Make sure all https://github.com/apache/camel-quarkus-examples/pulls[PRs] against `camel-quarkus-main` branch are merged. +* Upgrade to the Camel Quarkus version you just released ++ +[source,shell] +---- +$ NEW_CQ_VERSION=... # E.g. 2.2.0 +$ git fetch upstream +$ git checkout camel-quarkus-main +$ git reset --hard upstream/camel-quarkus-main +$ find . -type f -name pom.xml -exec sed -i "s|<camel-quarkus.version>[^<]*</camel-quarkus.version>|<camel-quarkus.version>$NEW_CQ_VERSION</camel-quarkus.version>|g" {} \; +$ ./mvnw-for-each.sh org.l2x6.cq:cq-maven-plugin:0.25.0:sync-example-properties +$ git commit -m "Upgrade to Camel Quarkus $NEW_CQ_VERSION" +---- ++ +* Make sure that the tests are still passing: ++ +[source,shell] +---- +$ ./mvnw-for-each.sh clean verify -Pnative +---- ++ +* If everything works for you locally, open a PR to merge `camel-quarkus-main` to `main` +* Once the PR is merged, tag the `main` branch with the `$NEW_CQ_VERSION`: ++ +[source,shell] +---- +$ git checkout main +$ git fetch upstream +$ git reset --hard upstream/main +$ ./mvnw-for-each.sh versions:set -DnewVersion=$NEW_CQ_VERSION Review comment: Indeed, a good sleep after, it's clearer now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
