djencks commented on pull request #6096: URL: https://github.com/apache/camel/pull/6096#issuecomment-921032720
I strongly think that changes in the number or information content of the bindy pages should be done under a separate JIRA issue. There are some comments scattered here and there that led me to believe that someone decided that one page for the three bindy flavors was the correct documentation approach, so if we change that I suggest that it be discussed separately from this set of changes which is intended to be format-only. My view based on the previous code and the identity of the rendered parts of the 3 bindy json files is that the existing single page is adequate as is. David Jencks > On Sep 16, 2021, at 8:07 AM, Zoran Regvart ***@***.***> wrote: > > > I did not push the Regen commit here to help with the review, the simplest solution for the Bindy issue that I could think of is in ee4f0ce <https://github.com/apache/camel/commit/ee4f0ceda8a2f11562e6c0df4723d33258f73360>. Though that rendered three identical tables because the JSON files are identical. Not sure what the fix here should be: > > use the single JSON file as the source for the options > fix metadata generation so single JSON file is generated > fix metadata generation so that it generates three different JSON files (based on appropriate configuration for each data format) > something else? > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub <https://github.com/apache/camel/pull/6096#issuecomment-920986898>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXWULG2LR7A35FDFXQ3UCIB4XANCNFSM5ECASYKQ>. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
