astefanutti commented on a change in pull request #2284: URL: https://github.com/apache/camel-k/pull/2284#discussion_r711927467
########## File path: config/samples/patch-integration-platform.yaml ########## @@ -0,0 +1,133 @@ +# --------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# --------------------------------------------------------------------------- + +apiVersion: camel.apache.org/v1 +kind: IntegrationPlatform +metadata: + name: camel-k +spec: + # + # The profile to be implemented by default + # ie. OpenShift, Kubernetes, Knative + # + profile: Openshift + # + # + # Options propogated to integrations Review comment: `propogated` -> `propagated` ########## File path: .github/workflows/knative.yml ########## @@ -34,14 +34,7 @@ on: branches: - main - "release-*" - paths-ignore: - - 'docs/**' Review comment: It seems this should be reverted before merging. ########## File path: e2e/support/test_support.go ########## @@ -1332,15 +1451,15 @@ func NumPods(ns string) func() int { func WithNewTestNamespace(t *testing.T, doRun func(string)) { ns := NewTestNamespace(false) - defer DeleteTestNamespace(t, ns) + // defer DeleteTestNamespace(t, ns) Review comment: It seems it can be removed. ########## File path: e2e/support/test_support.go ########## @@ -1332,15 +1451,15 @@ func NumPods(ns string) func() int { func WithNewTestNamespace(t *testing.T, doRun func(string)) { ns := NewTestNamespace(false) - defer DeleteTestNamespace(t, ns) + // defer DeleteTestNamespace(t, ns) defer UserCleanup() InvokeUserTestCode(t, ns.GetName(), doRun) } func WithNewTestNamespaceWithKnativeBroker(t *testing.T, doRun func(string)) { ns := NewTestNamespace(true) - defer DeleteTestNamespace(t, ns) + // defer DeleteTestNamespace(t, ns) Review comment: It seems it can be removed. ########## File path: e2e/support/test_support.go ########## @@ -1413,6 +1532,7 @@ func DeleteKnativeBroker(ns metav1.Object) { func DeleteTestNamespace(t *testing.T, ns ctrl.Object) { var oc bool var err error + fmt.Println("I SHOULD NOT BE EXECUTING THIS!") Review comment: It seems it can be removed. ########## File path: resources/builder/builder-role-binding-core.yaml ########## @@ -18,13 +18,13 @@ kind: RoleBinding apiVersion: rbac.authorization.k8s.io/v1 metadata: - name: camel-k-builder + name: camel-k-builder-core Review comment: Could this be called `camel-k-builder` to be symmetrical with the operator Role and RoleBinding? Also have the file renamed to `builder-role-binding` for the same reason? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
