astefanutti commented on a change in pull request #2650:
URL: https://github.com/apache/camel-k/pull/2650#discussion_r712133846
##########
File path: pkg/trait/environment.go
##########
@@ -31,6 +32,8 @@ type environmentTrait struct {
BaseTrait `property:",squash"`
// Enables injection of `NAMESPACE` and `POD_NAME` environment
variables (default `true`)
ContainerMeta *bool `property:"container-meta"
json:"containerMeta,omitempty"`
+ // A list of variables to be created on the Pod. Must have KEY=VALUE
syntax (ie, MY_VAR="my value").
+ Vars []string `property:"var" json:"var,omitempty"`
Review comment:
List JSON properties are usually pluralised, to have:
```json
traits:
- environment:
configuration:
vars:
- KEY: VALUE
- ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
