jamesnetherton commented on a change in pull request #54: URL: https://github.com/apache/camel-quarkus-examples/pull/54#discussion_r714506147
########## File path: jdbc-datasource/pom.xml ########## @@ -0,0 +1,257 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"; xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> + <modelVersion>4.0.0</modelVersion> + <groupId>org.apache.camel.quarkus.examples</groupId> + <artifactId>camel-quarkus-examples-jdbc-datasource</artifactId> + <version>2.2.0</version> + <name>Camel Quarkus :: Examples :: Jdbc - DatataSource - Log</name> + <description>Camel Quarkus Example :: Connect to Database using Datasource</description> + <properties> + <camel-quarkus.version>2.2.0</camel-quarkus.version> + <formatter-maven-plugin.version>2.11.0</formatter-maven-plugin.version> + <impsort-maven-plugin.version>1.3.2</impsort-maven-plugin.version> + <maven-compiler-plugin.version>3.8.0</maven-compiler-plugin.version> + <maven-jar-plugin.version>3.2.0</maven-jar-plugin.version> + <maven-resources-plugin.version>3.1.0</maven-resources-plugin.version> + <maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version> + <maven.compiler.source>11</maven.compiler.source> + <maven.compiler.target>11</maven.compiler.target> + <maven.compiler.testSource>${maven.compiler.source}</maven.compiler.testSource> + <maven.compiler.testTarget>${maven.compiler.target}</maven.compiler.testTarget> + <mycila-license.version>3.0</mycila-license.version> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> + <quarkus.version>2.2.0.Final</quarkus.version> + </properties> + <dependencyManagement> + <dependencies> + <dependency> + <groupId>org.apache.camel.quarkus</groupId> + <artifactId>camel-quarkus-bom</artifactId> + <version>${camel-quarkus.version}</version> + <type>pom</type> + <scope>import</scope> + </dependency> + <dependency> + <groupId>org.apache.camel.quarkus</groupId> + <artifactId>camel-quarkus-bom-test</artifactId> + <version>${camel-quarkus.version}</version> + <type>pom</type> + <scope>import</scope> + </dependency> + </dependencies> + </dependencyManagement> + <dependencies> + <dependency> + <groupId>org.apache.camel.quarkus</groupId> + <artifactId>camel-quarkus-microprofile-health</artifactId> Review comment: Unless there's a 'deploy to cloud' element to this example I guess we could live without the health extension? ########## File path: jdbc-datasource/src/main/resources/application.properties ########## @@ -0,0 +1,44 @@ +## --------------------------------------------------------------------------- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --------------------------------------------------------------------------- +# +# Quarkus +# +quarkus.banner.enabled = false +quarkus.log.file.enable = true + +camel.main.routes-include-pattern = file:src/main/resources/routes/camel-routes.xml + +#Create table automatically on database +quarkus.hibernate-orm.database.generation=drop-and-create Review comment: If this is the primary use of the JPA extension, maybe we should do the drop / create step manually via a startup observer or `@PostContruct` step. Example here: https://github.com/apache/camel-quarkus/blob/main/integration-tests/jdbc/src/main/java/org/apache/camel/quarkus/component/jdbc/CamelResource.java#L51-L65 Then we can remove the `camel-quarkus-jpa` dependency and the `Camel` entity class. ########## File path: jdbc-datasource/pom.xml ########## @@ -0,0 +1,257 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"; xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> + <modelVersion>4.0.0</modelVersion> + <groupId>org.apache.camel.quarkus.examples</groupId> + <artifactId>camel-quarkus-examples-jdbc-datasource</artifactId> + <version>2.2.0</version> Review comment: version should be `2.3.0-SNAPSHOT`. ########## File path: jdbc-datasource/README.adoc ########## @@ -0,0 +1,73 @@ += Connecting to a JDBC DataSource: A Camel Quarkus example +:cq-example-description: An example that shows how to define a Camel route in XML for tokenizing a CSV a file. Review comment: Description needs updating. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
