AlejandroME edited a comment on pull request #1262: URL: https://github.com/apache/camel-kafka-connector/pull/1262#issuecomment-933616964
Hello! 👋🏻 I've seen this PR and I wanted to chime in, because I refrained to use this connector in the past, because of this very same issue. @oscerd why is the OP's proposal "conceptually incorrect"? Technically speaking, the semantics of Kinesis requiring a mandatory partition key is a concern belonging to this connector only. Given that the current connector's design requires you to, either provide this key through a Kafka message header (which is a rarely used feature in most cases) or falling back to the exchange id (which doesn't work, hence this PR), a change in the connector's code makes sense, doesn't it? Also, why should an SMT solve what is, by definition, a bug in the connector's basic behavior? I ask these questions towards understanding how to proceed here. I'm very interested in seeing this fix in the connector, given that, in my particular case, we decided to go with AWS's "unofficial" connector, which is not stable. Thank you very much 🙇🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
