johnpoth commented on pull request #2696: URL: https://github.com/apache/camel-k/pull/2696#issuecomment-948638403
> Would it be possible to move that logic in the controller, like when reconciling the platform, instead of keeping it for the sole `kamel install`. That way it would work also whatever the installation mode. I remember we kept it there for Minikube to avoid extra RBAC and specific code, but with that KEP, it seems it would be both logical and possible. Thanks for reviewing ! As @nicolaferraro said I'm not sure how public the "kube-public" namespace really is: ``` $kubectl auth can-i get cm -n kube-public --as system:serviceaccount:camel-k:camel-k-operator no ``` Although by convention it is supposed to [be](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#:~:text=kube-public%20This%20namespace%20is,publicly%20throughout%20the%20whole%20cluster.): "kube-public This namespace is created automatically and is readable by all users (including those not authenticated). This namespace is mostly reserved for cluster usage, in case that some resources should be visible and readable publicly throughout the whole cluster. The public aspect of this namespace is only a convention, not a requirement." Anyhow I've updated the PR so the logic is also in the operator. I've left it in the client as well so that `kamel install` works without any other options (i.e without having to specify `--skip-operator-registry`). Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
