oscerd commented on a change in pull request #6413:
URL: https://github.com/apache/camel/pull/6413#discussion_r746466497
##########
File path:
components/camel-google/camel-google-pubsub/src/main/java/org/apache/camel/component/google/pubsub/GooglePubsubComponent.java
##########
@@ -87,6 +91,11 @@
description = "How many milliseconds should a producer be
allowed to terminate.")
private int publisherTerminationTimeout = 60000;
+ @Metadata(
+ label = "consumer",
+ description = "Additional retryable error codes for synchronous
pull. By default the PubSub client library retries ABORTED, UNAVAILABLE,
UNKNOWN")
+ private StatusCode.Code[] synchronousPullRetryableCodes = new
StatusCode.Code[0];
Review comment:
I wouldn't use internals classes for Camel option. It makes more sense
to set them as Strings and then convert when it's time to use them. If we start
going down this path, it will be a mess in all components. So please use a
different approach. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
