djencks commented on pull request #667: URL: https://github.com/apache/camel-website/pull/667#issuecomment-967161738
> On Nov 12, 2021, at 12:40 AM, Zoran Regvart ***@***.***> wrote: > > > @zregvart approved this pull request. > > I like what this is doing, I'm a bit worried about bundling several changes that could be done independently. > Simplest example is the change in c8d2a43 <https://github.com/apache/camel-website/commit/c8d2a43a8e27815c0cc469b60e6a800a0a906021>, that we can merge regardless of other changes in this PR. > I definitely could separate things into more focused sets of PRs, although it’s more work for me. For this one I was hoping having it in a separate commit would be adequate. It goes with the 2 main camel PRs: we’ll need one for 3.13.0 also I think. What happened is that Dan Allen pointed out on the Antora Zulip how to use inline anchors in table cells and I found that it dramatically speeded up the website build. Eventually I reordered the commits so this one came first. > Or bits of the playbook change here <https://github.com/apache/camel-website/pull/667/commits/a65e06b75c0d64478bfe7a18e5aa067b1ba5ee71#diff-0e8a7c2f91f241f59cc684e048c14593122447d39c4b8bfa6953cb5e91151aa2R100-R102>. > oops, that was an experiment that crept in. That should be in a PR that actually lets us use the result, I’ll take it out. > For this change <https://github.com/apache/camel-website/pull/667/commits/684fb0cb0a6237cf4366bfe1cafb7f36ee28f8b2> I think we're okay to merge it, but I think we need a discussion about issues like that to come up with a contract as to what versions of the documentation we keep around and for how long or what do we do with the content linking when we drop a version. > > Absolutely. As the commit comment points out, this is a temporary solution that will definitely break. I think that one approach would be a policy that pages should never disappear from documentation: they can get individual redirects to a new location (via page-aliases on the page at the new location) or at least some “this page doesn’t exist anymore for this reason” notification. Then links such as this problematic one can go to the no-version page and get redirected to the latest published version. > Bits in 8f32bab (#667) <https://github.com/apache/camel-website/pull/667/commits/8f32babbbba671fc85b375443b0318f63617fce8> I'd move to support directory (personal preference, not really important). > > I don’t understand what you mean, can you explain further? > In general, and if I understand this correctly, I think this solves a problem that we have in a very good way, and should make it easier on us to maintain the documentation. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/apache/camel-website/pull/667#pullrequestreview-804530163>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXTAZPKS72JKETL5VZTULTHHFANCNFSM5HYKMJNQ>. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
