zregvart commented on a change in pull request #2814:
URL: https://github.com/apache/camel-k/pull/2814#discussion_r764746224



##########
File path: pkg/install/kamelets.go
##########
@@ -19,30 +19,40 @@ package install
 
 import (
        "context"
+       "errors"
        "fmt"
-       "io/ioutil"
+       "io/fs"
+       "net/http"
        "os"
        "path"
+       "path/filepath"
        "strings"
 
-       "github.com/apache/camel-k/pkg/util"
+       "golang.org/x/sync/errgroup"
 
-       "github.com/pkg/errors"
        k8serrors "k8s.io/apimachinery/pkg/api/errors"
+       "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+       "k8s.io/apimachinery/pkg/runtime"
        "k8s.io/apimachinery/pkg/types"
 
+       ctrl "sigs.k8s.io/controller-runtime/pkg/client"
+
        "github.com/apache/camel-k/pkg/apis/camel/v1alpha1"
        "github.com/apache/camel-k/pkg/client"
+       "github.com/apache/camel-k/pkg/util"
        "github.com/apache/camel-k/pkg/util/defaults"
        "github.com/apache/camel-k/pkg/util/kubernetes"
+       "github.com/apache/camel-k/pkg/util/patch"
 )
 
 const (
        kameletDirEnv     = "KAMELET_CATALOG_DIR"
        defaultKameletDir = "/kamelets/"
 )
 
-// KameletCatalog installs the bundled KameletCatalog into one namespace.
+var hasServerSideApply = true

Review comment:
       Yeah in the grand scheme of things it could only be a performance issue, 
i.e. trying SSA multiple times, not a logic issue. My preference would be to 
use atomic value here, but I'll leave it up to you...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to