JiriOndrusek opened a new pull request #3370: URL: https://github.com/apache/camel-quarkus/pull/3370
…g issue if stored procedure is called #3260 fixes https://github.com/apache/camel-quarkus/issues/3327 Needs https://github.com/quarkusio/quarkus/issues/22058 to work correctly. I introduced an option to start sql test with derby started by docker. - to simulate external database (and not dev service). There are 2 things which may need some changes: 1. To run stored procedure on external derby db, there has to be a jar which is uploaded there. I created module `sql-derby` for that purpose and I put it on the same hierarchy level as `sql` test module. I'm not sure if this is the right approach, another option is to put both `sql` and `sql-derby` in one module. 2. I'm facing a problem with generated port number for docker container. If I let docker to generate its own random port, I'm not able propagate it back to datasource definition. Therefore there are 2 properties, which forces usage of docker derby db: ``` export SQL_USE_DERBY_DOCKER=true export SQL_USE_DERBY_PORT="#port" ``` On the other hand in current moment, when there is no CI automation for derby (see https://github.com/apache/camel-quarkus/issues/3083) it could stay in that way. WDYT? @aldettinger <!-- Uncomment and fill this section if your PR is not trivial [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes. [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #. [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough. [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea. [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request. [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
