davsclaus commented on a change in pull request #6677:
URL: https://github.com/apache/camel/pull/6677#discussion_r780245495



##########
File path: 
tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/ModelXmlParserGeneratorMojo.java
##########
@@ -223,7 +222,6 @@ private JavaClass generateParser(List<Class<?>> model, 
ClassLoader classLoader)
         parser.addImport(List.class);
         parser.addImport(ArrayList.class);
         
parser.addAnnotation(SuppressWarnings.class).setLiteralValue("\"unused\"");
-        parser.addAnnotation(Generated.class).setLiteralValue("\"" + 
getClass().getName() + "\"");

Review comment:
       Can we add a javadoc like the others do with
   ```
   /**
    * Generated by camel build tools - do NOT edit this file!
    */
   ```

##########
File path: 
tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/ModelXmlParserGeneratorMojo.java
##########
@@ -223,7 +222,6 @@ private JavaClass generateParser(List<Class<?>> model, 
ClassLoader classLoader)
         parser.addImport(List.class);
         parser.addImport(ArrayList.class);
         
parser.addAnnotation(SuppressWarnings.class).setLiteralValue("\"unused\"");
-        parser.addAnnotation(Generated.class).setLiteralValue("\"" + 
getClass().getName() + "\"");

Review comment:
       Can we add a class javadoc like we do with all the other source code 
generators
   ```
   /**
    * Generated by camel build tools - do NOT edit this file!
    */
   ```

##########
File path: 
core/camel-xml-io/src/generated/java/org/apache/camel/xml/in/ModelParser.java
##########
@@ -17,6 +17,10 @@
 
 //CHECKSTYLE:OFF
 
+
+/**
+Generated by Camel build tools - do NOT edit this file!

Review comment:
       ```
   /**
    * Generated by camel build tools - do NOT edit this file!
    */
   ```
   
   Almost there




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to