oscerd commented on a change in pull request #6726:
URL: https://github.com/apache/camel/pull/6726#discussion_r783900082
##########
File path:
components/camel-google/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/GoogleMailConfiguration.java
##########
@@ -124,4 +133,38 @@ public void setApplicationName(String applicationName) {
this.applicationName = applicationName;
}
+ public String getFilename() {
+ return filename;
+ }
+
+ /**
+ * Filename "*.json" with credentials for Service account
+ */
+ public void setFilename(String filename) {
Review comment:
The keyResource needs to be read through resourceHelper while passing
the variable to the makeClient, it should something like
https://github.com/apache/camel/blob/main/components/camel-google/camel-google-functions/src/main/java/org/apache/camel/component/google/functions/GoogleCloudFunctionsClientFactory.java#L43
or something like resourceUri in
https://camel.apache.org/components/3.14.x/mustache-component.html or any other
templating component. I don't know what the makeClient expect, but I suppose
this would be a much more complete a flexible approach than passing a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
