astefanutti commented on a change in pull request #2711:
URL: https://github.com/apache/camel-k/pull/2711#discussion_r791727889
##########
File path: e2e/common/traits/health_test.go
##########
@@ -35,7 +36,18 @@ import (
v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
)
+/*
+ * TODO
+ * Test needs to be modified as route for unsecured http is not created on OCP.
Review comment:
It seems the comment is taken from the route trait tests. This test do
not create a Route.
##########
File path: config/rbac/kustomization.yaml
##########
@@ -25,6 +25,7 @@ resources:
- user-cluster-role.yaml
- operator-role-events.yaml
- operator-role-knative.yaml
+- operator-role-olm.yaml
Review comment:
What is this new role for? I fail to see why it should be bound to the
operator ServiceAccount.
##########
File path: e2e/common/operator_metrics_test.go
##########
@@ -171,6 +172,17 @@ func TestMetrics(t *testing.T) {
))
})
+ /*
+ * TODO
+ * The duration_seconds tests keep randomly failing on OCP4
with slightly different duration values
+ * May need to lessen the strict checking parameters
+ *
+ * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+ */
+ if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {
Review comment:
Could the problematic tests be deactivated only on OCP4? Most of them
run fine on other environments, so it'd be better not to disable them globally
in the interim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
