ppalaga commented on pull request #3481: URL: https://github.com/apache/camel-quarkus/pull/3481#issuecomment-1033593706
Thanks again for your great work @zhfeng! I have a couple of cosmetic and practical nitpicks for the future: - Could you please keep the changes that belong logically together in a single commit as far as possible? That makes it not only much easier to read the history but it also makes it easier to backport to older branches like 2.7.x, which I am doing right now. - Please also try to mimic the prevaling style of the commit messages as far as possible. I do not think we have any strict and explicit rules there, but there is certainly a couple of things vast majority of contributors do, e.g. starting commit messages with a capital letter or mentioning the issue number at the end. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
