astefanutti commented on a change in pull request #3008:
URL: https://github.com/apache/camel-k/pull/3008#discussion_r805913550
##########
File path: pkg/builder/image.go
##########
@@ -120,7 +120,7 @@ func jvmDockerfile(ctx *builderContext) error {
}
func incrementalImageContext(ctx *builderContext) error {
- if ctx.Build.BaseImage != "" {
+ if ctx.Build.BaseImage != "" && ctx.Build.BaseImage !=
defaults.BaseImage() {
Review comment:
The branch logic, to fallback to "standard" image, should be removed.
The logic to configure either "standard" or "incremental" should be done in
the _builder_ trait, where a configuration parameter could be added, and the
corresponding build step added. It's a bit more subtle than that, because
"incremental" image build step should be deactivated for Quarkus native build,
from the _quarkus_ trait, that already manipulates the build steps, but that
should be quite straightforward.
There is also the following TODO that may be removed while we are at it:
https://github.com/apache/camel-k/blob/478ca56e54eadc3cfa9a10bf592935a34d37d9e7/pkg/builder/image.go#L148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
