This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 9412ba1 CAMEL-17763: cleaned up unused exceptions in camel-metrics
9412ba1 is described below
commit 9412ba13d1c4a5e072af17b0e53277b454ad4bc9
Author: Otavio Rodolfo Piske <[email protected]>
AuthorDate: Tue Mar 8 13:37:36 2022 +0100
CAMEL-17763: cleaned up unused exceptions in camel-metrics
---
.../metrics/AbstractMetricsProducerTest.java | 23 ++++++++---------
.../component/metrics/CounterEndpointTest.java | 12 ++++-----
.../component/metrics/CounterProducerTest.java | 4 +--
.../camel/component/metrics/CounterRouteTest.java | 4 +--
.../camel/component/metrics/GaugeEndpointTest.java | 8 +++---
.../camel/component/metrics/GaugeProducerTest.java | 6 ++---
.../component/metrics/HistogramEndpointTest.java | 10 ++++----
.../component/metrics/HistogramProducerTest.java | 4 +--
.../component/metrics/HistogramRouteTest.java | 4 +--
.../camel/component/metrics/MeterEndpointTest.java | 10 ++++----
.../camel/component/metrics/MeterProducerTest.java | 4 +--
.../camel/component/metrics/MeterRouteTest.java | 4 +--
.../metrics/MetricComponentSpringTest.java | 4 +--
.../metrics/MetricsComponentRouteTest.java | 2 +-
.../component/metrics/MetricsComponentTest.java | 30 +++++++++++-----------
.../component/metrics/MetricsEndpointTest.java | 16 ++++++------
.../camel/component/metrics/MetricsTypeTest.java | 2 +-
.../camel/component/metrics/TimerEndpointTest.java | 10 ++++----
.../camel/component/metrics/TimerProducerTest.java | 18 ++++++-------
.../camel/component/metrics/TimerRouteTest.java | 4 +--
.../ExceptionRouteMetricsMessageHistoryTest.java | 4 +--
.../messagehistory/ManagedMessageHistoryTest.java | 4 +--
.../messagehistory/MetricsMessageHistoryTest.java | 4 +--
.../routepolicy/ManagedMetricsRoutePolicyTest.java | 4 +--
.../MetricsRoutePolicyMulticastSubRouteTest.java | 4 +--
.../MetricsRoutePolicySubRouteTest.java | 4 +--
.../routepolicy/MetricsRoutePolicyTest.java | 4 +--
.../spi/InstrumentedThreadPoolFactoryTest.java | 8 +++---
28 files changed, 107 insertions(+), 108 deletions(-)
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/AbstractMetricsProducerTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/AbstractMetricsProducerTest.java
index f725b81..e909937 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/AbstractMetricsProducerTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/AbstractMetricsProducerTest.java
@@ -62,11 +62,10 @@ public class AbstractMetricsProducerTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
okProducer = new AbstractMetricsProducer(endpoint) {
@Override
- protected void doProcess(Exchange exchange, MetricsEndpoint
endpoint, MetricRegistry registry, String metricsName)
- throws Exception {
+ protected void doProcess(Exchange exchange, MetricsEndpoint
endpoint, MetricRegistry registry, String metricsName) {
}
};
failProducer = new AbstractMetricsProducer(endpoint) {
@@ -110,7 +109,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testGetMetricsName() throws Exception {
+ public void testGetMetricsName() {
when(in.getHeader(HEADER_METRIC_NAME, String.class)).thenReturn("A");
assertThat(okProducer.getMetricsName(in, "value"), is("A"));
inOrder.verify(in, times(1)).getHeader(HEADER_METRIC_NAME,
String.class);
@@ -118,7 +117,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testGetMetricsNameNotSet() throws Exception {
+ public void testGetMetricsNameNotSet() {
when(in.getHeader(HEADER_METRIC_NAME, String.class)).thenReturn(null);
assertThat(okProducer.getMetricsName(in, "name"), is("name"));
inOrder.verify(in, times(1)).getHeader(HEADER_METRIC_NAME,
String.class);
@@ -126,7 +125,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testGetStringHeader() throws Exception {
+ public void testGetStringHeader() {
when(in.getHeader(HEADER_METRIC_NAME, String.class)).thenReturn("A");
assertThat(okProducer.getStringHeader(in, HEADER_METRIC_NAME,
"value"), is("A"));
inOrder.verify(in, times(1)).getHeader(HEADER_METRIC_NAME,
String.class);
@@ -134,7 +133,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testGetStringHeaderWithNullValue() throws Exception {
+ public void testGetStringHeaderWithNullValue() {
when(in.getHeader(HEADER_METRIC_NAME, String.class)).thenReturn(null);
assertThat(okProducer.getStringHeader(in, HEADER_METRIC_NAME,
"value"), is("value"));
inOrder.verify(in, times(1)).getHeader(HEADER_METRIC_NAME,
String.class);
@@ -142,7 +141,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testGetStringHeaderWithWhiteSpaces() throws Exception {
+ public void testGetStringHeaderWithWhiteSpaces() {
when(in.getHeader(HEADER_METRIC_NAME, String.class)).thenReturn(" ");
assertThat(okProducer.getStringHeader(in, HEADER_METRIC_NAME,
"value"), is("value"));
inOrder.verify(in, times(1)).getHeader(HEADER_METRIC_NAME,
String.class);
@@ -150,7 +149,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testGetStringHeaderWithEmptySrting() throws Exception {
+ public void testGetStringHeaderWithEmptySrting() {
when(in.getHeader(HEADER_METRIC_NAME, String.class)).thenReturn("");
assertThat(okProducer.getStringHeader(in, HEADER_METRIC_NAME,
"value"), is("value"));
inOrder.verify(in, times(1)).getHeader(HEADER_METRIC_NAME,
String.class);
@@ -158,7 +157,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testGetLongHeader() throws Exception {
+ public void testGetLongHeader() {
when(in.getHeader(HEADER_HISTOGRAM_VALUE, 19L,
Long.class)).thenReturn(201L);
assertThat(okProducer.getLongHeader(in, HEADER_HISTOGRAM_VALUE, 19L),
is(201L));
inOrder.verify(in, times(1)).getHeader(HEADER_HISTOGRAM_VALUE, 19L,
Long.class);
@@ -166,7 +165,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testClearMetricsHeaders() throws Exception {
+ public void testClearMetricsHeaders() {
when(in.removeHeaders(HEADER_PATTERN)).thenReturn(true);
assertThat(okProducer.clearMetricsHeaders(in), is(true));
inOrder.verify(in, times(1)).removeHeaders(HEADER_PATTERN);
@@ -174,7 +173,7 @@ public class AbstractMetricsProducerTest {
}
@Test
- public void testClearRealHeaders() throws Exception {
+ public void testClearRealHeaders() {
Message msg = new DefaultMessage(new DefaultCamelContext());
Object val = new Object();
msg.setHeader(HEADER_HISTOGRAM_VALUE, 109L);
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterEndpointTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterEndpointTest.java
index 598b7a8..cbd5bdb 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterEndpointTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterEndpointTest.java
@@ -47,7 +47,7 @@ public class CounterEndpointTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
endpoint = new MetricsEndpoint(null, null, registry,
MetricsType.COUNTER, METRICS_NAME);
inOrder = Mockito.inOrder(registry);
}
@@ -58,7 +58,7 @@ public class CounterEndpointTest {
}
@Test
- public void testCounterEndpoint() throws Exception {
+ public void testCounterEndpoint() {
assertThat(endpoint.getRegistry(), is(registry));
assertThat(endpoint.getMetricsName(), is(METRICS_NAME));
assertThat(endpoint.getIncrement(), is(nullValue()));
@@ -73,24 +73,24 @@ public class CounterEndpointTest {
}
@Test
- public void testGetIncrement() throws Exception {
+ public void testGetIncrement() {
assertThat(endpoint.getIncrement(), is(nullValue()));
}
@Test
- public void testSetIncrement() throws Exception {
+ public void testSetIncrement() {
assertThat(endpoint.getIncrement(), is(nullValue()));
endpoint.setIncrement(VALUE);
assertThat(endpoint.getIncrement(), is(VALUE));
}
@Test
- public void testGetDecrement() throws Exception {
+ public void testGetDecrement() {
assertThat(endpoint.getDecrement(), is(nullValue()));
}
@Test
- public void testSetDecrement() throws Exception {
+ public void testSetDecrement() {
assertThat(endpoint.getDecrement(), is(nullValue()));
endpoint.setDecrement(VALUE);
assertThat(endpoint.getDecrement(), is(VALUE));
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterProducerTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterProducerTest.java
index 8a1ced9..e4071de 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterProducerTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterProducerTest.java
@@ -66,7 +66,7 @@ public class CounterProducerTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
producer = new CounterProducer(endpoint);
inOrder = Mockito.inOrder(endpoint, exchange, registry, counter, in);
lenient().when(registry.counter(METRICS_NAME)).thenReturn(counter);
@@ -74,7 +74,7 @@ public class CounterProducerTest {
}
@Test
- public void testCounterProducer() throws Exception {
+ public void testCounterProducer() {
assertThat(producer.getEndpoint().equals(endpoint), is(true));
}
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterRouteTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterRouteTest.java
index f943fb8..7ab7484 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterRouteTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/CounterRouteTest.java
@@ -88,10 +88,10 @@ public class CounterRouteTest extends
CamelSpringTestSupport {
}
@Override
- protected RoutesBuilder createRouteBuilder() throws Exception {
+ protected RoutesBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:in-1")
.to("metrics:counter:A?increment=5")
.to("mock:out");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeEndpointTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeEndpointTest.java
index 5b5483d..d997858 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeEndpointTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeEndpointTest.java
@@ -42,12 +42,12 @@ public class GaugeEndpointTest {
private MetricsEndpoint endpoint;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
endpoint = new MetricsEndpoint(null, null, registry,
MetricsType.GAUGE, METRICS_NAME);
}
@Test
- public void testGaugeEndpoint() throws Exception {
+ public void testGaugeEndpoint() {
assertThat(endpoint.getRegistry(), is(registry));
assertThat(endpoint.getMetricsName(), is(METRICS_NAME));
assertThat(endpoint.getSubject(), is(nullValue()));
@@ -61,12 +61,12 @@ public class GaugeEndpointTest {
}
@Test
- public void testGetSubject() throws Exception {
+ public void testGetSubject() {
assertThat(endpoint.getSubject(), is(nullValue()));
}
@Test
- public void testSetSubject() throws Exception {
+ public void testSetSubject() {
endpoint.setSubject(VALUE);
assertThat(endpoint.getSubject(), is(VALUE));
}
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeProducerTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeProducerTest.java
index 6bfc0ad..a7c84b5 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeProducerTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/GaugeProducerTest.java
@@ -60,7 +60,7 @@ public class GaugeProducerTest {
private GaugeProducer producer;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
lenient().when(endpoint.getRegistry()).thenReturn(registry);
lenient().when(endpoint.getSubject()).thenReturn(VALUE);
lenient().when(endpoint.getMetricsName()).thenReturn(METRICS_NAME);
@@ -69,12 +69,12 @@ public class GaugeProducerTest {
}
@Test
- public void testGaugeProducer() throws Exception {
+ public void testGaugeProducer() {
assertThat(producer.getEndpoint().equals(endpoint), is(true));
}
@Test
- public void testDefault() throws Exception {
+ public void testDefault() {
verify(registry, times(1)).register(eq(METRICS_NAME), argThat(new
ArgumentMatcher<CamelMetricsGauge>() {
@Override
public boolean matches(CamelMetricsGauge argument) {
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramEndpointTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramEndpointTest.java
index d122d06..26dde69 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramEndpointTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramEndpointTest.java
@@ -47,18 +47,18 @@ public class HistogramEndpointTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
endpoint = new MetricsEndpoint(null, null, registry,
MetricsType.HISTOGRAM, METRICS_NAME);
inOrder = Mockito.inOrder(registry);
}
@AfterEach
- public void tearDown() throws Exception {
+ public void tearDown() {
inOrder.verifyNoMoreInteractions();
}
@Test
- public void testHistogramEndpoint() throws Exception {
+ public void testHistogramEndpoint() {
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint.getRegistry(), is(registry));
assertThat(endpoint.getMetricsName(), is(METRICS_NAME));
@@ -72,12 +72,12 @@ public class HistogramEndpointTest {
}
@Test
- public void testGetValue() throws Exception {
+ public void testGetValue() {
assertThat(endpoint.getValue(), is(nullValue()));
}
@Test
- public void testSetValue() throws Exception {
+ public void testSetValue() {
assertThat(endpoint.getValue(), is(nullValue()));
endpoint.setValue(VALUE);
assertThat(endpoint.getValue(), is(VALUE));
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramProducerTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramProducerTest.java
index 050136d..4311e79 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramProducerTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramProducerTest.java
@@ -61,7 +61,7 @@ public class HistogramProducerTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
producer = new HistogramProducer(endpoint);
inOrder = Mockito.inOrder(endpoint, registry, histogram, exchange, in);
lenient().when(registry.histogram(METRICS_NAME)).thenReturn(histogram);
@@ -69,7 +69,7 @@ public class HistogramProducerTest {
}
@Test
- public void testHistogramProducer() throws Exception {
+ public void testHistogramProducer() {
assertThat(producer.getEndpoint().equals(endpoint), is(true));
}
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramRouteTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramRouteTest.java
index 10f645f9..d7d4aee 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramRouteTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/HistogramRouteTest.java
@@ -74,10 +74,10 @@ public class HistogramRouteTest extends
CamelSpringTestSupport {
}
@Override
- protected RoutesBuilder createRouteBuilder() throws Exception {
+ protected RoutesBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:in")
.to("metrics:histogram:A?value=332491")
.to("mock:out");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterEndpointTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterEndpointTest.java
index 8955b36..de0222d 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterEndpointTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterEndpointTest.java
@@ -47,18 +47,18 @@ public class MeterEndpointTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
endpoint = new MetricsEndpoint(null, null, registry,
MetricsType.METER, METRICS_NAME);
inOrder = Mockito.inOrder(registry);
}
@AfterEach
- public void tearDown() throws Exception {
+ public void tearDown() {
inOrder.verifyNoMoreInteractions();
}
@Test
- public void testMeterEndpoint() throws Exception {
+ public void testMeterEndpoint() {
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint.getRegistry(), is(registry));
assertThat(endpoint.getMetricsName(), is(METRICS_NAME));
@@ -72,12 +72,12 @@ public class MeterEndpointTest {
}
@Test
- public void testGetMark() throws Exception {
+ public void testGetMark() {
assertThat(endpoint.getMark(), is(nullValue()));
}
@Test
- public void testSetMark() throws Exception {
+ public void testSetMark() {
assertThat(endpoint.getMark(), is(nullValue()));
endpoint.setMark(VALUE);
assertThat(endpoint.getMark(), is(VALUE));
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterProducerTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterProducerTest.java
index c03372c..7fdde82 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterProducerTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterProducerTest.java
@@ -63,7 +63,7 @@ public class MeterProducerTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
producer = new MeterProducer(endpoint);
inOrder = Mockito.inOrder(endpoint, registry, meter, exchange, in);
lenient().when(registry.meter(METRICS_NAME)).thenReturn(meter);
@@ -71,7 +71,7 @@ public class MeterProducerTest {
}
@Test
- public void testMeterProducer() throws Exception {
+ public void testMeterProducer() {
assertThat(producer, is(notNullValue()));
assertThat(producer.getEndpoint(), is(equalTo(endpoint)));
}
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterRouteTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterRouteTest.java
index 3d42b0a..c0fd72b 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterRouteTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MeterRouteTest.java
@@ -79,10 +79,10 @@ public class MeterRouteTest extends CamelSpringTestSupport {
}
@Override
- protected RoutesBuilder createRouteBuilder() throws Exception {
+ protected RoutesBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:in-1")
.to("metrics:meter:A?mark=3179")
.to("mock:out");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricComponentSpringTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricComponentSpringTest.java
index 5e536f2..7a5488d 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricComponentSpringTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricComponentSpringTest.java
@@ -71,10 +71,10 @@ public class MetricComponentSpringTest extends
CamelSpringTestSupport {
}
@Override
- protected RoutesBuilder createRouteBuilder() throws Exception {
+ protected RoutesBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:in")
.to("metrics:counter:A?increment=512")
.to("mock:out");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentRouteTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentRouteTest.java
index f78f2ca..134ee06 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentRouteTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentRouteTest.java
@@ -87,7 +87,7 @@ public class MetricsComponentRouteTest extends
CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
public void configure() {
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentTest.java
index 67392c6..ff1a6cc 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsComponentTest.java
@@ -63,7 +63,7 @@ public class MetricsComponentTest {
private MetricsComponent component;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
component = new MetricsComponent();
inOrder = Mockito.inOrder(camelContext, camelRegistry, metricRegistry);
}
@@ -141,7 +141,7 @@ public class MetricsComponentTest {
}
@Test
- public void testGetMetricsName() throws Exception {
+ public void testGetMetricsName() {
assertThat(component.getMetricsName("meter:metric-a"), is("metric-a"));
assertThat(component.getMetricsName("meter:metric-a:sub-b"),
is("metric-a:sub-b"));
assertThat(component.getMetricsName("metric-a"), is("metric-a"));
@@ -150,60 +150,60 @@ public class MetricsComponentTest {
}
@Test
- public void testCreateNewEndpointForCounter() throws Exception {
+ public void testCreateNewEndpointForCounter() {
Endpoint endpoint = new MetricsEndpoint(null, null, metricRegistry,
MetricsType.COUNTER, "a name");
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint, is(instanceOf(MetricsEndpoint.class)));
}
@Test
- public void testCreateNewEndpointForMeter() throws Exception {
+ public void testCreateNewEndpointForMeter() {
Endpoint endpoint = new MetricsEndpoint(null, null, metricRegistry,
MetricsType.METER, "a name");
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint, is(instanceOf(MetricsEndpoint.class)));
}
@Test
- public void testCreateNewEndpointForGauge() throws Exception {
+ public void testCreateNewEndpointForGauge() {
MetricsEndpoint endpoint = new MetricsEndpoint(null, null,
metricRegistry, MetricsType.GAUGE, "a name");
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint, is(instanceOf(MetricsEndpoint.class)));
}
@Test
- public void testCreateNewEndpointForHistogram() throws Exception {
+ public void testCreateNewEndpointForHistogram() {
Endpoint endpoint = new MetricsEndpoint(null, null, metricRegistry,
MetricsType.HISTOGRAM, "a name");
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint, is(instanceOf(MetricsEndpoint.class)));
}
@Test
- public void testCreateNewEndpointForTimer() throws Exception {
+ public void testCreateNewEndpointForTimer() {
Endpoint endpoint = new MetricsEndpoint(null, null, metricRegistry,
MetricsType.TIMER, "a name");
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint, is(instanceOf(MetricsEndpoint.class)));
}
@Test
- public void testGetMetricsType() throws Exception {
+ public void testGetMetricsType() {
for (MetricsType type : EnumSet.allOf(MetricsType.class)) {
assertThat(component.getMetricsType(type.toString() +
":metrics-name"), is(type));
}
}
@Test
- public void testGetMetricsTypeNotSet() throws Exception {
+ public void testGetMetricsTypeNotSet() {
assertThat(component.getMetricsType("no-metrics-type"),
is(MetricsComponent.DEFAULT_METRICS_TYPE));
}
@Test
- public void testGetMetricsTypeNotFound() throws Exception {
+ public void testGetMetricsTypeNotFound() {
assertThrows(RuntimeCamelException.class,
() ->
component.getMetricsType("unknown-metrics:metrics-name"));
}
@Test
- public void testGetOrCreateMetricRegistryFoundInCamelRegistry() throws
Exception {
+ public void testGetOrCreateMetricRegistryFoundInCamelRegistry() {
when(camelRegistry.lookupByNameAndType("name",
MetricRegistry.class)).thenReturn(metricRegistry);
MetricRegistry result =
MetricsComponent.getOrCreateMetricRegistry(camelRegistry, "name");
assertThat(result, is(metricRegistry));
@@ -212,7 +212,7 @@ public class MetricsComponentTest {
}
@Test
- public void testGetOrCreateMetricRegistryFoundInCamelRegistryByType()
throws Exception {
+ public void testGetOrCreateMetricRegistryFoundInCamelRegistryByType() {
when(camelRegistry.lookupByNameAndType("name",
MetricRegistry.class)).thenReturn(null);
when(camelRegistry.findByType(MetricRegistry.class)).thenReturn(Collections.singleton(metricRegistry));
MetricRegistry result =
MetricsComponent.getOrCreateMetricRegistry(camelRegistry, "name");
@@ -223,7 +223,7 @@ public class MetricsComponentTest {
}
@Test
- public void testGetOrCreateMetricRegistryNotFoundInCamelRegistry() throws
Exception {
+ public void testGetOrCreateMetricRegistryNotFoundInCamelRegistry() {
when(camelRegistry.lookupByNameAndType("name",
MetricRegistry.class)).thenReturn(null);
when(camelRegistry.findByType(MetricRegistry.class)).thenReturn(Collections.<MetricRegistry>
emptySet());
MetricRegistry result =
MetricsComponent.getOrCreateMetricRegistry(camelRegistry, "name");
@@ -235,7 +235,7 @@ public class MetricsComponentTest {
}
@Test
- public void testGetMetricRegistryFromCamelRegistry() throws Exception {
+ public void testGetMetricRegistryFromCamelRegistry() {
when(camelRegistry.lookupByNameAndType("name",
MetricRegistry.class)).thenReturn(metricRegistry);
MetricRegistry result =
MetricsComponent.getMetricRegistryFromCamelRegistry(camelRegistry, "name");
assertThat(result, is(metricRegistry));
@@ -244,7 +244,7 @@ public class MetricsComponentTest {
}
@Test
- public void testCreateMetricRegistry() throws Exception {
+ public void testCreateMetricRegistry() {
MetricRegistry registry = MetricsComponent.createMetricRegistry();
assertThat(registry, is(notNullValue()));
}
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsEndpointTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsEndpointTest.java
index 7b1b172..22859fa 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsEndpointTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsEndpointTest.java
@@ -57,10 +57,10 @@ public class MetricsEndpointTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
endpoint = new MetricsEndpoint(null, null, registry,
MetricsType.METER, METRICS_NAME) {
@Override
- public Producer createProducer() throws Exception {
+ public Producer createProducer() {
return null;
}
@@ -73,34 +73,34 @@ public class MetricsEndpointTest {
}
@AfterEach
- public void tearDown() throws Exception {
+ public void tearDown() {
inOrder.verifyNoMoreInteractions();
}
@Test
- public void testAbstractMetricsEndpoint() throws Exception {
+ public void testAbstractMetricsEndpoint() {
assertThat(endpoint.getMetricsName(), is(METRICS_NAME));
assertThat(endpoint.getRegistry(), is(registry));
}
@Test
- public void testCreateConsumer() throws Exception {
+ public void testCreateConsumer() {
assertThrows(RuntimeCamelException.class,
() -> endpoint.createConsumer(processor));
}
@Test
- public void testIsSingleton() throws Exception {
+ public void testIsSingleton() {
assertThat(endpoint.isSingleton(), is(true));
}
@Test
- public void testGetRegistry() throws Exception {
+ public void testGetRegistry() {
assertThat(endpoint.getRegistry(), is(registry));
}
@Test
- public void testGetMetricsName() throws Exception {
+ public void testGetMetricsName() {
assertThat(endpoint.getMetricsName(), is(METRICS_NAME));
}
}
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsTypeTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsTypeTest.java
index 6c866b3..0bceafe 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsTypeTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/MetricsTypeTest.java
@@ -26,7 +26,7 @@ import static org.hamcrest.Matchers.is;
public class MetricsTypeTest {
@Test
- public void testGetByName() throws Exception {
+ public void testGetByName() {
for (MetricsType type : EnumSet.allOf(MetricsType.class)) {
MetricsType t = MetricsType.getByName(type.toString());
assertThat(t, is(type));
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerEndpointTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerEndpointTest.java
index 960504a..156f49c 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerEndpointTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerEndpointTest.java
@@ -46,18 +46,18 @@ public class TimerEndpointTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
endpoint = new MetricsEndpoint(null, null, registry,
MetricsType.TIMER, METRICS_NAME);
inOrder = Mockito.inOrder(registry);
}
@AfterEach
- public void tearDown() throws Exception {
+ public void tearDown() {
inOrder.verifyNoMoreInteractions();
}
@Test
- public void testTimerEndpoint() throws Exception {
+ public void testTimerEndpoint() {
assertThat(endpoint, is(notNullValue()));
assertThat(endpoint.getRegistry(), is(registry));
assertThat(endpoint.getMetricsName(), is(METRICS_NAME));
@@ -71,12 +71,12 @@ public class TimerEndpointTest {
}
@Test
- public void testGetAction() throws Exception {
+ public void testGetAction() {
assertThat(endpoint.getAction(), is(nullValue()));
}
@Test
- public void testSetAction() throws Exception {
+ public void testSetAction() {
assertThat(endpoint.getAction(), is(nullValue()));
endpoint.setAction(MetricsTimerAction.start);
assertThat(endpoint.getAction(), is(MetricsTimerAction.start));
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java
index cda1cf0..762cef5 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java
@@ -67,7 +67,7 @@ public class TimerProducerTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
producer = new TimerProducer(endpoint);
inOrder = Mockito.inOrder(endpoint, exchange, registry, timer,
context, in);
lenient().when(registry.timer(METRICS_NAME)).thenReturn(timer);
@@ -76,7 +76,7 @@ public class TimerProducerTest {
}
@Test
- public void testTimerProducer() throws Exception {
+ public void testTimerProducer() {
assertThat(producer, is(notNullValue()));
assertThat(producer.getEndpoint().equals(endpoint), is(true));
}
@@ -174,7 +174,7 @@ public class TimerProducerTest {
}
@Test
- public void testHandleStart() throws Exception {
+ public void testHandleStart() {
when(exchange.getProperty(PROPERTY_NAME,
Timer.Context.class)).thenReturn(null);
producer.handleStart(exchange, registry, METRICS_NAME);
inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME,
Timer.Context.class);
@@ -185,7 +185,7 @@ public class TimerProducerTest {
}
@Test
- public void testHandleStartAlreadyRunning() throws Exception {
+ public void testHandleStartAlreadyRunning() {
when(exchange.getProperty(PROPERTY_NAME,
Timer.Context.class)).thenReturn(context);
producer.handleStart(exchange, registry, METRICS_NAME);
inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME,
Timer.Context.class);
@@ -193,7 +193,7 @@ public class TimerProducerTest {
}
@Test
- public void testHandleStop() throws Exception {
+ public void testHandleStop() {
when(exchange.getProperty(PROPERTY_NAME,
Timer.Context.class)).thenReturn(context);
producer.handleStop(exchange, METRICS_NAME);
inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME,
Timer.Context.class);
@@ -203,7 +203,7 @@ public class TimerProducerTest {
}
@Test
- public void testHandleStopContextNotFound() throws Exception {
+ public void testHandleStopContextNotFound() {
when(exchange.getProperty(PROPERTY_NAME,
Timer.Context.class)).thenReturn(null);
producer.handleStop(exchange, METRICS_NAME);
inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME,
Timer.Context.class);
@@ -211,12 +211,12 @@ public class TimerProducerTest {
}
@Test
- public void testGetPropertyName() throws Exception {
+ public void testGetPropertyName() {
assertThat(producer.getPropertyName(METRICS_NAME), is("timer" + ":" +
METRICS_NAME));
}
@Test
- public void testGetTimerContextFromExchange() throws Exception {
+ public void testGetTimerContextFromExchange() {
when(exchange.getProperty(PROPERTY_NAME,
Timer.Context.class)).thenReturn(context);
assertThat(producer.getTimerContextFromExchange(exchange,
PROPERTY_NAME), is(context));
inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME,
Timer.Context.class);
@@ -224,7 +224,7 @@ public class TimerProducerTest {
}
@Test
- public void testGetTimerContextFromExchangeNotFound() throws Exception {
+ public void testGetTimerContextFromExchangeNotFound() {
when(exchange.getProperty(PROPERTY_NAME,
Timer.Context.class)).thenReturn(null);
assertThat(producer.getTimerContextFromExchange(exchange,
PROPERTY_NAME), is(nullValue()));
inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME,
Timer.Context.class);
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerRouteTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerRouteTest.java
index ca78e35..8520a23 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerRouteTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerRouteTest.java
@@ -60,10 +60,10 @@ public class TimerRouteTest extends CamelSpringTestSupport {
private InOrder inOrder;
@Override
- protected RoutesBuilder createRouteBuilder() throws Exception {
+ protected RoutesBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:in-1")
.to("metrics:timer:A?action=start")
.to("mock:out");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ExceptionRouteMetricsMessageHistoryTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ExceptionRouteMetricsMessageHistoryTest.java
index ea55a1e..e69c9f8 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ExceptionRouteMetricsMessageHistoryTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ExceptionRouteMetricsMessageHistoryTest.java
@@ -81,10 +81,10 @@ public class ExceptionRouteMetricsMessageHistoryTest
extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
onException(Exception.class)
.routeId("ExceptionRoute")
.log("Exception received.")
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ManagedMessageHistoryTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ManagedMessageHistoryTest.java
index ea64387..c4a9c13 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ManagedMessageHistoryTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/ManagedMessageHistoryTest.java
@@ -120,10 +120,10 @@ public class ManagedMessageHistoryTest extends
CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("seda:foo").to("mock:foo").id("foo");
from("seda:bar").to("mock:bar").id("bar").to("mock:baz").id("baz");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/MetricsMessageHistoryTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/MetricsMessageHistoryTest.java
index 9e15967..282259d 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/MetricsMessageHistoryTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/messagehistory/MetricsMessageHistoryTest.java
@@ -78,10 +78,10 @@ public class MetricsMessageHistoryTest extends
CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("seda:foo")
.to("mock:foo").id("foo");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/ManagedMetricsRoutePolicyTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/ManagedMetricsRoutePolicyTest.java
index 6785629..91431ad 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/ManagedMetricsRoutePolicyTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/ManagedMetricsRoutePolicyTest.java
@@ -97,10 +97,10 @@ public class ManagedMetricsRoutePolicyTest extends
CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("seda:foo").routeId("foo").to("metrics:counter:test").to("mock:result");
from("seda:bar").routeId("bar").to("mock:result");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyMulticastSubRouteTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyMulticastSubRouteTest.java
index bf8b332..1654290 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyMulticastSubRouteTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyMulticastSubRouteTest.java
@@ -71,10 +71,10 @@ public class MetricsRoutePolicyMulticastSubRouteTest
extends CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("direct:foo").routeId("foo").to("mock:foo");
from("direct:bar").routeId("bar").multicast().to("mock:bar1",
"mock:bar2");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicySubRouteTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicySubRouteTest.java
index b656dad..9464231 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicySubRouteTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicySubRouteTest.java
@@ -57,10 +57,10 @@ public class MetricsRoutePolicySubRouteTest extends
CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("seda:foo").routeId("foo")
.to("direct:bar")
.to("mock:foo");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyTest.java
index 29fbe5e..81b0315 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/routepolicy/MetricsRoutePolicyTest.java
@@ -59,10 +59,10 @@ public class MetricsRoutePolicyTest extends
CamelTestSupport {
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
+ protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("seda:foo").routeId("foo")
.to("mock:result");
diff --git
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/spi/InstrumentedThreadPoolFactoryTest.java
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/spi/InstrumentedThreadPoolFactoryTest.java
index b95b9d5..6facd0c 100644
---
a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/spi/InstrumentedThreadPoolFactoryTest.java
+++
b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/spi/InstrumentedThreadPoolFactoryTest.java
@@ -63,7 +63,7 @@ public class InstrumentedThreadPoolFactoryTest {
private InOrder inOrder;
@BeforeEach
- public void setUp() throws Exception {
+ public void setUp() {
profile = new ThreadPoolProfile(METRICS_NAME);
profile.setDefaultProfile(false);
profile.setMaxPoolSize(10);
@@ -79,7 +79,7 @@ public class InstrumentedThreadPoolFactoryTest {
}
@Test
- public void testNewCacheThreadPool() throws Exception {
+ public void testNewCacheThreadPool() {
final ExecutorService executorService =
instrumentedThreadPoolFactory.newCachedThreadPool(threadFactory);
assertThat(executorService, is(notNullValue()));
assertThat(executorService,
is(instanceOf(InstrumentedExecutorService.class)));
@@ -91,7 +91,7 @@ public class InstrumentedThreadPoolFactoryTest {
}
@Test
- public void testNewThreadPool() throws Exception {
+ public void testNewThreadPool() {
final ExecutorService executorService =
instrumentedThreadPoolFactory.newThreadPool(profile, threadFactory);
assertThat(executorService, is(notNullValue()));
assertThat(executorService,
is(instanceOf(InstrumentedExecutorService.class)));
@@ -103,7 +103,7 @@ public class InstrumentedThreadPoolFactoryTest {
}
@Test
- public void testNewScheduledThreadPool() throws Exception {
+ public void testNewScheduledThreadPool() {
final ScheduledExecutorService scheduledExecutorService
=
instrumentedThreadPoolFactory.newScheduledThreadPool(profile, threadFactory);