essobedo commented on a change in pull request #7245:
URL: https://github.com/apache/camel/pull/7245#discussion_r831972354



##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -219,15 +218,12 @@ protected void doExecuteConfigurationFiles(CamelCatalog 
catalog) throws MojoExec
         // TODO: implement me
 
         Set<File> propertiesFiles = new LinkedHashSet<>();
-        List list = project.getResources();
-        for (Object obj : list) {
-            Resource dir = (Resource) obj;
+        for (Resource dir : project.getResources()) {
             findPropertiesFiles(new File(dir.getDirectory()), propertiesFiles);
         }
         if (includeTest) {
             list = project.getTestResources();
-            for (Object obj : list) {
-                Resource dir = (Resource) obj;
+            for (Resource dir : list) {

Review comment:
       ditto

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -650,6 +486,170 @@ protected void doExecuteRoutes(CamelCatalog catalog) 
throws MojoExecutionExcepti
         }
     }
 
+    private String 
buildSimpleSummaryMessage(List<CamelSimpleExpressionDetails> simpleExpressions, 
int simpleErrors) {
+        String simpleSummary;
+        if (simpleErrors == 0) {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation success: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        } else {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation error: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        }
+        return simpleSummary;
+    }
+
+    private String buildEndpointSummaryMessage(List<CamelEndpointDetails> 
endpoints, int endpointErrors, int unknownComponents, int incapableErrors, int 
deprecatedOptions) {
+        String endpointSummary;
+        if (endpointErrors == 0) {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation success: (%s 
= passed, %s = invalid, %s = incapable, %s = unknown components, %s = 
deprecated options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        } else {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation error: (%s = 
passed, %s = invalid, %s = incapable, %s = unknown components, %s = deprecated 
options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        }
+        return endpointSummary;
+    }
+
+    private String buildValidationPassedMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = buildValidationSuccessMessage("Endpoint validation 
passed at: ", detail.getClassName(), detail.getLineNumber(), 
detail.getMethodName(), detail.getFileName(), result.getUri());
+
+        return sb.toString();
+    }
+
+    private String buildValidationErrorMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = new StringBuilder();
+        sb.append("Endpoint validation error at: ");
+        if (detail.getClassName() != null && detail.getLineNumber() != null) {
+            // this is from java code
+            sb.append(detail.getClassName());
+            if (detail.getMethodName() != null) {
+                sb.append(".").append(detail.getMethodName());
+            }
+            
sb.append("(").append(asSimpleClassName(detail.getClassName())).append(".java:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else if (detail.getLineNumber() != null) {
+            // this is from xml
+            String fqn = stripRootPath(asRelativeFile(detail.getFileName()));
+            if (fqn.endsWith(".xml")) {
+                fqn = fqn.substring(0, fqn.length() - 4);
+                fqn = asPackageName(fqn);
+            }
+            sb.append(fqn);
+            sb.append("(").append(asSimpleClassName(fqn)).append(".xml:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else {
+            sb.append(detail.getFileName());
+        }
+        sb.append("\n\n");
+        String out = result.summaryErrorMessage(false, ignoreDeprecated, true);
+        sb.append(out);
+        sb.append("\n\n");
+        return sb.toString();
+    }
+
+    private void parseXmlRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+
+            // parse the xml source code and find Camel routes
+            String fqn = file.getPath();
+            String baseDir = ".";
+
+            InputStream is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteEndpoints(is, baseDir, fqn, 
fileEndpoints);
+            is.close();
+            // need a new stream
+            is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteSimpleExpressions(is, baseDir, fqn, 
fileSimpleExpressions);
+            is.close();
+
+            if (duplicateRouteId) {
+                // need a new stream
+                is = new FileInputStream(file);
+                XmlRouteParser.parseXmlRouteRouteIds(is, baseDir, fqn, 
fileRouteIds);
+                is.close();
+            }
+
+            // add what we found in this file to the total list
+            endpoints.addAll(fileEndpoints);
+            simpleExpressions.addAll(fileSimpleExpressions);
+            routeIds.addAll(fileRouteIds);
+        } catch (Exception e) {
+            getLog().warn("Error parsing xml file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void parseJavaRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<String> unparsable = new ArrayList<>();
+
+            // parse the java source code and find Camel RouteBuilder classes
+            String fqn = file.getPath();
+            String baseDir = ".";
+            JavaType out = Roaster.parse(file);
+            // we should only parse java classes (not interfaces and enums etc)
+            if (out instanceof JavaClassSource) {
+                JavaClassSource clazz = (JavaClassSource) out;
+                RouteBuilderParser.parseRouteBuilderEndpoints(clazz, baseDir, 
fqn, fileEndpoints, unparsable, includeTest);
+                RouteBuilderParser.parseRouteBuilderSimpleExpressions(clazz, 
baseDir, fqn, fileSimpleExpressions);
+                if (duplicateRouteId) {
+                    RouteBuilderParser.parseRouteBuilderRouteIds(clazz, 
baseDir, fqn, fileRouteIds);
+                }
+
+                // add what we found in this file to the total list
+                endpoints.addAll(fileEndpoints);
+                simpleExpressions.addAll(fileSimpleExpressions);
+                routeIds.addAll(fileRouteIds);
+
+                // was there any unparsable?
+                if (logUnparseable && !unparsable.isEmpty()) {
+                    for (String uri : unparsable) {
+                        getLog().warn("Cannot parse endpoint uri " + uri + " 
in java file " + file);
+                    }
+                }
+            }
+        } catch (Exception e) {
+            getLog().warn("Error parsing java file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void findXmlRouters(Set<File> xmlFiles) {
+        if (includeXml) {
+            List<Resource> list = project.getResources();
+            for (Resource dir : list) {
+                findXmlFiles(new File(dir.getDirectory()), xmlFiles);
+            }
+            if (includeTest) {
+                list = project.getTestResources();
+                for (Resource dir : list) {

Review comment:
       ```suggestion
                   for (Resource dir : project.getTestResources()) {
   ```

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -1056,33 +995,29 @@ private String asRelativeFile(String name) {
     private String stripRootPath(String name) {
         // strip out any leading source / resource directory
 
-        List list = project.getCompileSourceRoots();
-        for (Object obj : list) {
-            String dir = (String) obj;
+        List<String> list = project.getCompileSourceRoots();
+        for (String dir : list) {

Review comment:
       ```suggestion
           for (String dir : project.getCompileSourceRoots()) {
   ```

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -650,6 +486,170 @@ protected void doExecuteRoutes(CamelCatalog catalog) 
throws MojoExecutionExcepti
         }
     }
 
+    private String 
buildSimpleSummaryMessage(List<CamelSimpleExpressionDetails> simpleExpressions, 
int simpleErrors) {
+        String simpleSummary;
+        if (simpleErrors == 0) {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation success: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        } else {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation error: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        }
+        return simpleSummary;
+    }
+
+    private String buildEndpointSummaryMessage(List<CamelEndpointDetails> 
endpoints, int endpointErrors, int unknownComponents, int incapableErrors, int 
deprecatedOptions) {
+        String endpointSummary;
+        if (endpointErrors == 0) {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation success: (%s 
= passed, %s = invalid, %s = incapable, %s = unknown components, %s = 
deprecated options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        } else {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation error: (%s = 
passed, %s = invalid, %s = incapable, %s = unknown components, %s = deprecated 
options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        }
+        return endpointSummary;
+    }
+
+    private String buildValidationPassedMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = buildValidationSuccessMessage("Endpoint validation 
passed at: ", detail.getClassName(), detail.getLineNumber(), 
detail.getMethodName(), detail.getFileName(), result.getUri());
+
+        return sb.toString();
+    }
+
+    private String buildValidationErrorMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = new StringBuilder();
+        sb.append("Endpoint validation error at: ");
+        if (detail.getClassName() != null && detail.getLineNumber() != null) {
+            // this is from java code
+            sb.append(detail.getClassName());
+            if (detail.getMethodName() != null) {
+                sb.append(".").append(detail.getMethodName());
+            }
+            
sb.append("(").append(asSimpleClassName(detail.getClassName())).append(".java:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else if (detail.getLineNumber() != null) {
+            // this is from xml
+            String fqn = stripRootPath(asRelativeFile(detail.getFileName()));
+            if (fqn.endsWith(".xml")) {
+                fqn = fqn.substring(0, fqn.length() - 4);
+                fqn = asPackageName(fqn);
+            }
+            sb.append(fqn);
+            sb.append("(").append(asSimpleClassName(fqn)).append(".xml:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else {
+            sb.append(detail.getFileName());
+        }
+        sb.append("\n\n");
+        String out = result.summaryErrorMessage(false, ignoreDeprecated, true);
+        sb.append(out);
+        sb.append("\n\n");
+        return sb.toString();
+    }
+
+    private void parseXmlRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+
+            // parse the xml source code and find Camel routes
+            String fqn = file.getPath();
+            String baseDir = ".";
+
+            InputStream is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteEndpoints(is, baseDir, fqn, 
fileEndpoints);
+            is.close();
+            // need a new stream
+            is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteSimpleExpressions(is, baseDir, fqn, 
fileSimpleExpressions);
+            is.close();
+
+            if (duplicateRouteId) {
+                // need a new stream
+                is = new FileInputStream(file);
+                XmlRouteParser.parseXmlRouteRouteIds(is, baseDir, fqn, 
fileRouteIds);
+                is.close();
+            }
+
+            // add what we found in this file to the total list
+            endpoints.addAll(fileEndpoints);
+            simpleExpressions.addAll(fileSimpleExpressions);
+            routeIds.addAll(fileRouteIds);
+        } catch (Exception e) {
+            getLog().warn("Error parsing xml file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void parseJavaRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<String> unparsable = new ArrayList<>();
+
+            // parse the java source code and find Camel RouteBuilder classes
+            String fqn = file.getPath();
+            String baseDir = ".";
+            JavaType out = Roaster.parse(file);
+            // we should only parse java classes (not interfaces and enums etc)
+            if (out instanceof JavaClassSource) {
+                JavaClassSource clazz = (JavaClassSource) out;
+                RouteBuilderParser.parseRouteBuilderEndpoints(clazz, baseDir, 
fqn, fileEndpoints, unparsable, includeTest);
+                RouteBuilderParser.parseRouteBuilderSimpleExpressions(clazz, 
baseDir, fqn, fileSimpleExpressions);
+                if (duplicateRouteId) {
+                    RouteBuilderParser.parseRouteBuilderRouteIds(clazz, 
baseDir, fqn, fileRouteIds);
+                }
+
+                // add what we found in this file to the total list
+                endpoints.addAll(fileEndpoints);
+                simpleExpressions.addAll(fileSimpleExpressions);
+                routeIds.addAll(fileRouteIds);
+
+                // was there any unparsable?
+                if (logUnparseable && !unparsable.isEmpty()) {
+                    for (String uri : unparsable) {
+                        getLog().warn("Cannot parse endpoint uri " + uri + " 
in java file " + file);
+                    }
+                }
+            }
+        } catch (Exception e) {
+            getLog().warn("Error parsing java file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void findXmlRouters(Set<File> xmlFiles) {
+        if (includeXml) {
+            List<Resource> list = project.getResources();
+            for (Resource dir : list) {
+                findXmlFiles(new File(dir.getDirectory()), xmlFiles);
+            }
+            if (includeTest) {
+                list = project.getTestResources();
+                for (Resource dir : list) {
+                    findXmlFiles(new File(dir.getDirectory()), xmlFiles);
+                }
+            }
+        }
+    }
+
+    private void findJavaRouteBuilderClasses(Set<File> javaFiles) {
+        if (includeJava) {
+            List<String> list = project.getCompileSourceRoots();
+            for (String dir : list) {
+                findJavaFiles(new File(dir), javaFiles);
+            }
+            if (includeTest) {
+                list = project.getTestCompileSourceRoots();
+                for (String dir : list) {

Review comment:
       ```suggestion
                   for (String dir : project.getTestCompileSourceRoots()) {
   ```

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -650,6 +486,170 @@ protected void doExecuteRoutes(CamelCatalog catalog) 
throws MojoExecutionExcepti
         }
     }
 
+    private String 
buildSimpleSummaryMessage(List<CamelSimpleExpressionDetails> simpleExpressions, 
int simpleErrors) {
+        String simpleSummary;
+        if (simpleErrors == 0) {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation success: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        } else {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation error: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        }
+        return simpleSummary;
+    }
+
+    private String buildEndpointSummaryMessage(List<CamelEndpointDetails> 
endpoints, int endpointErrors, int unknownComponents, int incapableErrors, int 
deprecatedOptions) {
+        String endpointSummary;
+        if (endpointErrors == 0) {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation success: (%s 
= passed, %s = invalid, %s = incapable, %s = unknown components, %s = 
deprecated options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        } else {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation error: (%s = 
passed, %s = invalid, %s = incapable, %s = unknown components, %s = deprecated 
options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        }
+        return endpointSummary;
+    }
+
+    private String buildValidationPassedMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = buildValidationSuccessMessage("Endpoint validation 
passed at: ", detail.getClassName(), detail.getLineNumber(), 
detail.getMethodName(), detail.getFileName(), result.getUri());
+
+        return sb.toString();
+    }
+
+    private String buildValidationErrorMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = new StringBuilder();
+        sb.append("Endpoint validation error at: ");
+        if (detail.getClassName() != null && detail.getLineNumber() != null) {
+            // this is from java code
+            sb.append(detail.getClassName());
+            if (detail.getMethodName() != null) {
+                sb.append(".").append(detail.getMethodName());
+            }
+            
sb.append("(").append(asSimpleClassName(detail.getClassName())).append(".java:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else if (detail.getLineNumber() != null) {
+            // this is from xml
+            String fqn = stripRootPath(asRelativeFile(detail.getFileName()));
+            if (fqn.endsWith(".xml")) {
+                fqn = fqn.substring(0, fqn.length() - 4);
+                fqn = asPackageName(fqn);
+            }
+            sb.append(fqn);
+            sb.append("(").append(asSimpleClassName(fqn)).append(".xml:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else {
+            sb.append(detail.getFileName());
+        }
+        sb.append("\n\n");
+        String out = result.summaryErrorMessage(false, ignoreDeprecated, true);
+        sb.append(out);
+        sb.append("\n\n");
+        return sb.toString();
+    }
+
+    private void parseXmlRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+
+            // parse the xml source code and find Camel routes
+            String fqn = file.getPath();
+            String baseDir = ".";
+
+            InputStream is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteEndpoints(is, baseDir, fqn, 
fileEndpoints);
+            is.close();
+            // need a new stream
+            is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteSimpleExpressions(is, baseDir, fqn, 
fileSimpleExpressions);
+            is.close();
+
+            if (duplicateRouteId) {
+                // need a new stream
+                is = new FileInputStream(file);
+                XmlRouteParser.parseXmlRouteRouteIds(is, baseDir, fqn, 
fileRouteIds);
+                is.close();
+            }
+
+            // add what we found in this file to the total list
+            endpoints.addAll(fileEndpoints);
+            simpleExpressions.addAll(fileSimpleExpressions);
+            routeIds.addAll(fileRouteIds);
+        } catch (Exception e) {
+            getLog().warn("Error parsing xml file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void parseJavaRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<String> unparsable = new ArrayList<>();
+
+            // parse the java source code and find Camel RouteBuilder classes
+            String fqn = file.getPath();
+            String baseDir = ".";
+            JavaType out = Roaster.parse(file);
+            // we should only parse java classes (not interfaces and enums etc)
+            if (out instanceof JavaClassSource) {
+                JavaClassSource clazz = (JavaClassSource) out;
+                RouteBuilderParser.parseRouteBuilderEndpoints(clazz, baseDir, 
fqn, fileEndpoints, unparsable, includeTest);
+                RouteBuilderParser.parseRouteBuilderSimpleExpressions(clazz, 
baseDir, fqn, fileSimpleExpressions);
+                if (duplicateRouteId) {
+                    RouteBuilderParser.parseRouteBuilderRouteIds(clazz, 
baseDir, fqn, fileRouteIds);
+                }
+
+                // add what we found in this file to the total list
+                endpoints.addAll(fileEndpoints);
+                simpleExpressions.addAll(fileSimpleExpressions);
+                routeIds.addAll(fileRouteIds);
+
+                // was there any unparsable?
+                if (logUnparseable && !unparsable.isEmpty()) {
+                    for (String uri : unparsable) {
+                        getLog().warn("Cannot parse endpoint uri " + uri + " 
in java file " + file);
+                    }
+                }
+            }
+        } catch (Exception e) {
+            getLog().warn("Error parsing java file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void findXmlRouters(Set<File> xmlFiles) {
+        if (includeXml) {
+            List<Resource> list = project.getResources();
+            for (Resource dir : list) {
+                findXmlFiles(new File(dir.getDirectory()), xmlFiles);
+            }
+            if (includeTest) {
+                list = project.getTestResources();
+                for (Resource dir : list) {
+                    findXmlFiles(new File(dir.getDirectory()), xmlFiles);
+                }
+            }
+        }
+    }
+
+    private void findJavaRouteBuilderClasses(Set<File> javaFiles) {
+        if (includeJava) {
+            List<String> list = project.getCompileSourceRoots();
+            for (String dir : list) {

Review comment:
       ```suggestion
               for (String dir : project.getCompileSourceRoots()) {
   ```

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -931,9 +871,8 @@ private static int countRouteId(List<CamelRouteDetails> 
details, String routeId)
     private static String findCamelVersion(MavenProject project) {
         Dependency candidate = null;
 
-        List list = project.getDependencies();
-        for (Object obj : list) {
-            Dependency dep = (Dependency) obj;
+        List<Dependency> list = project.getDependencies();
+        for (Dependency dep : list) {

Review comment:
       ```suggestion
           for (Dependency dep : project.getDependencies()) {
   ```

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -1056,33 +995,29 @@ private String asRelativeFile(String name) {
     private String stripRootPath(String name) {
         // strip out any leading source / resource directory
 
-        List list = project.getCompileSourceRoots();
-        for (Object obj : list) {
-            String dir = (String) obj;
+        List<String> list = project.getCompileSourceRoots();
+        for (String dir : list) {
             dir = asRelativeFile(dir);
             if (name.startsWith(dir)) {
                 return name.substring(dir.length() + 1);
             }
         }
         list = project.getTestCompileSourceRoots();
-        for (Object obj : list) {
-            String dir = (String) obj;
+        for (String dir : list) {
             dir = asRelativeFile(dir);
             if (name.startsWith(dir)) {
                 return name.substring(dir.length() + 1);
             }
         }
-        List resources = project.getResources();
-        for (Object obj : resources) {
-            Resource resource = (Resource) obj;
+        List<Resource> resources = project.getResources();
+        for (Resource resource : resources) {
             String dir = asRelativeFile(resource.getDirectory());
             if (name.startsWith(dir)) {
                 return name.substring(dir.length() + 1);
             }
         }
         resources = project.getTestResources();
-        for (Object obj : resources) {
-            Resource resource = (Resource) obj;
+        for (Resource resource : resources) {

Review comment:
       ditto

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -650,6 +486,170 @@ protected void doExecuteRoutes(CamelCatalog catalog) 
throws MojoExecutionExcepti
         }
     }
 
+    private String 
buildSimpleSummaryMessage(List<CamelSimpleExpressionDetails> simpleExpressions, 
int simpleErrors) {
+        String simpleSummary;
+        if (simpleErrors == 0) {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation success: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        } else {
+            int ok = simpleExpressions.size() - simpleErrors;
+            simpleSummary = String.format("Simple validation error: (%s = 
passed, %s = invalid)", ok, simpleErrors);
+        }
+        return simpleSummary;
+    }
+
+    private String buildEndpointSummaryMessage(List<CamelEndpointDetails> 
endpoints, int endpointErrors, int unknownComponents, int incapableErrors, int 
deprecatedOptions) {
+        String endpointSummary;
+        if (endpointErrors == 0) {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation success: (%s 
= passed, %s = invalid, %s = incapable, %s = unknown components, %s = 
deprecated options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        } else {
+            int ok = endpoints.size() - endpointErrors - incapableErrors - 
unknownComponents;
+            endpointSummary = String.format("Endpoint validation error: (%s = 
passed, %s = invalid, %s = incapable, %s = unknown components, %s = deprecated 
options)",
+                ok, endpointErrors, incapableErrors, unknownComponents, 
deprecatedOptions);
+        }
+        return endpointSummary;
+    }
+
+    private String buildValidationPassedMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = buildValidationSuccessMessage("Endpoint validation 
passed at: ", detail.getClassName(), detail.getLineNumber(), 
detail.getMethodName(), detail.getFileName(), result.getUri());
+
+        return sb.toString();
+    }
+
+    private String buildValidationErrorMessage(CamelEndpointDetails detail, 
EndpointValidationResult result) {
+        StringBuilder sb = new StringBuilder();
+        sb.append("Endpoint validation error at: ");
+        if (detail.getClassName() != null && detail.getLineNumber() != null) {
+            // this is from java code
+            sb.append(detail.getClassName());
+            if (detail.getMethodName() != null) {
+                sb.append(".").append(detail.getMethodName());
+            }
+            
sb.append("(").append(asSimpleClassName(detail.getClassName())).append(".java:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else if (detail.getLineNumber() != null) {
+            // this is from xml
+            String fqn = stripRootPath(asRelativeFile(detail.getFileName()));
+            if (fqn.endsWith(".xml")) {
+                fqn = fqn.substring(0, fqn.length() - 4);
+                fqn = asPackageName(fqn);
+            }
+            sb.append(fqn);
+            sb.append("(").append(asSimpleClassName(fqn)).append(".xml:");
+            sb.append(detail.getLineNumber()).append(")");
+        } else {
+            sb.append(detail.getFileName());
+        }
+        sb.append("\n\n");
+        String out = result.summaryErrorMessage(false, ignoreDeprecated, true);
+        sb.append(out);
+        sb.append("\n\n");
+        return sb.toString();
+    }
+
+    private void parseXmlRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+
+            // parse the xml source code and find Camel routes
+            String fqn = file.getPath();
+            String baseDir = ".";
+
+            InputStream is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteEndpoints(is, baseDir, fqn, 
fileEndpoints);
+            is.close();
+            // need a new stream
+            is = new FileInputStream(file);
+            XmlRouteParser.parseXmlRouteSimpleExpressions(is, baseDir, fqn, 
fileSimpleExpressions);
+            is.close();
+
+            if (duplicateRouteId) {
+                // need a new stream
+                is = new FileInputStream(file);
+                XmlRouteParser.parseXmlRouteRouteIds(is, baseDir, fqn, 
fileRouteIds);
+                is.close();
+            }
+
+            // add what we found in this file to the total list
+            endpoints.addAll(fileEndpoints);
+            simpleExpressions.addAll(fileSimpleExpressions);
+            routeIds.addAll(fileRouteIds);
+        } catch (Exception e) {
+            getLog().warn("Error parsing xml file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void parseJavaRouteFile(List<CamelEndpointDetails> endpoints, 
List<CamelSimpleExpressionDetails> simpleExpressions, List<CamelRouteDetails> 
routeIds, File file) {
+        try {
+            List<CamelEndpointDetails> fileEndpoints = new ArrayList<>();
+            List<CamelRouteDetails> fileRouteIds = new ArrayList<>();
+            List<CamelSimpleExpressionDetails> fileSimpleExpressions = new 
ArrayList<>();
+            List<String> unparsable = new ArrayList<>();
+
+            // parse the java source code and find Camel RouteBuilder classes
+            String fqn = file.getPath();
+            String baseDir = ".";
+            JavaType out = Roaster.parse(file);
+            // we should only parse java classes (not interfaces and enums etc)
+            if (out instanceof JavaClassSource) {
+                JavaClassSource clazz = (JavaClassSource) out;
+                RouteBuilderParser.parseRouteBuilderEndpoints(clazz, baseDir, 
fqn, fileEndpoints, unparsable, includeTest);
+                RouteBuilderParser.parseRouteBuilderSimpleExpressions(clazz, 
baseDir, fqn, fileSimpleExpressions);
+                if (duplicateRouteId) {
+                    RouteBuilderParser.parseRouteBuilderRouteIds(clazz, 
baseDir, fqn, fileRouteIds);
+                }
+
+                // add what we found in this file to the total list
+                endpoints.addAll(fileEndpoints);
+                simpleExpressions.addAll(fileSimpleExpressions);
+                routeIds.addAll(fileRouteIds);
+
+                // was there any unparsable?
+                if (logUnparseable && !unparsable.isEmpty()) {
+                    for (String uri : unparsable) {
+                        getLog().warn("Cannot parse endpoint uri " + uri + " 
in java file " + file);
+                    }
+                }
+            }
+        } catch (Exception e) {
+            getLog().warn("Error parsing java file " + file + " code due " + 
e.getMessage(), e);
+        }
+    }
+
+    private void findXmlRouters(Set<File> xmlFiles) {
+        if (includeXml) {
+            List<Resource> list = project.getResources();
+            for (Resource dir : list) {

Review comment:
       ```suggestion
               for (Resource dir : project.getResources()) {
   ```

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -1056,33 +995,29 @@ private String asRelativeFile(String name) {
     private String stripRootPath(String name) {
         // strip out any leading source / resource directory
 
-        List list = project.getCompileSourceRoots();
-        for (Object obj : list) {
-            String dir = (String) obj;
+        List<String> list = project.getCompileSourceRoots();
+        for (String dir : list) {
             dir = asRelativeFile(dir);
             if (name.startsWith(dir)) {
                 return name.substring(dir.length() + 1);
             }
         }
         list = project.getTestCompileSourceRoots();
-        for (Object obj : list) {
-            String dir = (String) obj;
+        for (String dir : list) {

Review comment:
       ditto

##########
File path: 
catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/ValidateMojo.java
##########
@@ -1056,33 +995,29 @@ private String asRelativeFile(String name) {
     private String stripRootPath(String name) {
         // strip out any leading source / resource directory
 
-        List list = project.getCompileSourceRoots();
-        for (Object obj : list) {
-            String dir = (String) obj;
+        List<String> list = project.getCompileSourceRoots();
+        for (String dir : list) {
             dir = asRelativeFile(dir);
             if (name.startsWith(dir)) {
                 return name.substring(dir.length() + 1);
             }
         }
         list = project.getTestCompileSourceRoots();
-        for (Object obj : list) {
-            String dir = (String) obj;
+        for (String dir : list) {
             dir = asRelativeFile(dir);
             if (name.startsWith(dir)) {
                 return name.substring(dir.length() + 1);
             }
         }
-        List resources = project.getResources();
-        for (Object obj : resources) {
-            Resource resource = (Resource) obj;
+        List<Resource> resources = project.getResources();
+        for (Resource resource : resources) {

Review comment:
       ```suggestion
           for (Resource resource : project.getResources()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to