astefanutti commented on a change in pull request #3153:
URL: https://github.com/apache/camel-k/pull/3153#discussion_r838507832
##########
File path: e2e/support/test_support.go
##########
@@ -1719,9 +1719,9 @@ func UserCleanup() {
command.Stderr = os.Stderr
command.Stdout = os.Stdout
if err := command.Run(); err != nil {
- fmt.Printf("An error occurred during user cleanup
command execution: %v\n", err)
+ fmt.Fprintf(command.Stderr, "An error occurred during
user cleanup command execution: %v\n", err)
Review comment:
`Fprintln` operands are appended with white spaces, e.g.:
```golang
fmt.Fprintf(command.Stderr, "An error occurred during user cleanup command
execution: %v\n", err)
```
Can be turned into:
```golang
fmt.Fprintln(command.Stderr, "An error occurred during user cleanup command
execution:", err.Error())
```
I think for all the statements where formatting is actually used for
appending strings, then `Fprintln` is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
